media/base/android/media_codec_bridge.cc - Issue 1254293003: MediaCodecPlayer implementation (stage 4 - preroll)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_codec_bridge.cc

Issue 1254293003: MediaCodecPlayer implementation (stage 4 - preroll) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mtplayer-browserseek

Patch Set: Moved pending buffer to Java side, preroll after decoder creation and Release() Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/base/android/media_codec_audio_decoder.cc ('K') | « media/base/android/media_codec_bridge.h ('k') | media/base/android/media_codec_decoder.h » ('j') | media/base/android/media_codec_player.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_codec_bridge.cc

diff --git a/media/base/android/media_codec_bridge.cc b/media/base/android/media_codec_bridge.cc

index f076b218e1a6f3baf45eac97276dc656f4b7f0dd..dccccd1adbf43be79cf5e98f87b54900a4b91322 100644

--- a/media/base/android/media_codec_bridge.cc

+++ b/media/base/android/media_codec_bridge.cc

@@ -697,7 +697,9 @@ bool AudioCodecBridge::ConfigureMediaFormat(jobject j_format,

return true;

}

-int64 AudioCodecBridge::PlayOutputBuffer(int index, size_t size) {

+int64 AudioCodecBridge::PlayOutputBuffer(int index,

+ size_t size,

+ bool postpone) {

DCHECK_LE(0, index);

int numBytes = base::checked_cast<int>(size);

JNIEnv* env = AttachCurrentThread();

@@ -707,8 +709,8 @@ int64 AudioCodecBridge::PlayOutputBuffer(int index, size_t size) {

ScopedJavaLocalRef<jbyteArray> byte_array =

base::android::ToJavaByteArray(env, buffer, numBytes);

- return Java_MediaCodecBridge_playOutputBuffer(

- env, media_codec(), byte_array.obj());

+ return Java_MediaCodecBridge_playOutputBuffer(env, media_codec(),

+ byte_array.obj(), postpone);

}

void AudioCodecBridge::SetVolume(double volume) {