MediaCodecPlayer implementation (stage 4 - preroll)

media/base/android/media_codec_player.cc

Index: media/base/android/media_codec_player.cc
diff --git a/media/base/android/media_codec_player.cc b/media/base/android/media_codec_player.cc
index e1b7562c4e2f29c940fd6cf776485a9e16426bdb..d3f0044a92689a071005e6af3a56fa80fe2ed20e 100644
--- a/media/base/android/media_codec_player.cc
+++ b/media/base/android/media_codec_player.cc
@@ -432,6 +432,8 @@ void MediaCodecPlayer::OnDemuxerSeekDone(
 
   interpolator_.SetBounds(seek_time, seek_time);
   audio_decoder_->SetBaseTimestamp(seek_time);
+  audio_decoder_->SetNeedsPreroll(true);

[Tima Vaisburd, 2015/08/01 04:34:43]

Would it be better to put needs_preroll = true inside Flush() instead?

+  video_decoder_->SetNeedsPreroll(true);
 
   // The Flush() might set the state to kStateError.
   if (state_ == kStateError) {
@@ -555,12 +557,31 @@ void MediaCodecPlayer::OnPrefetchDone() {
   StartPlaybackOrBrowserSeek();
 }
 
+void MediaCodecPlayer::OnPrerollDone() {
+  DCHECK(GetMediaTaskRunner()->BelongsToCurrentThread());
+  DVLOG(1) << __FUNCTION__;
+
+  if (!(audio_decoder_->IsPrerollDone() && video_decoder_->IsPrerollDone())) {
+    DVLOG(1) << __FUNCTION__ << " both audio and video needs to be done"
+             << " prerolling, ignoring";
+    return;  // Wait until both streams are done prerolling.
+  }
+
+  if (!AudioFinished())
+    audio_decoder_->ResumeAfterPreroll();
+  if (!VideoFinished())
+    video_decoder_->ResumeAfterPreroll();
+}
+
 void MediaCodecPlayer::OnStopDone() {
   DCHECK(GetMediaTaskRunner()->BelongsToCurrentThread());
   DVLOG(1) << __FUNCTION__;
 
-  if (!(audio_decoder_->IsStopped() && video_decoder_->IsStopped()))
+  if (!(audio_decoder_->IsStopped() && video_decoder_->IsStopped())) {
+    DVLOG(1) << __FUNCTION__ << " both audio and video has to be stopped"
+             << ", ignoring";
     return;  // Wait until other stream is stopped
+  }
 
   // At this point decoder threads should not be running
   if (interpolator_.interpolating())
@@ -922,6 +943,7 @@ void MediaCodecPlayer::CreateDecoders() {
                                        media_weak_this_, DemuxerStream::AUDIO),
       base::Bind(&MediaCodecPlayer::OnStarvation, media_weak_this_,
                  DemuxerStream::AUDIO),
+      base::Bind(&MediaCodecPlayer::OnPrerollDone, media_weak_this_),
       base::Bind(&MediaCodecPlayer::OnStopDone, media_weak_this_),
       internal_error_cb_,
       base::Bind(&MediaCodecPlayer::OnTimeIntervalUpdate, media_weak_this_,
@@ -932,6 +954,7 @@ void MediaCodecPlayer::CreateDecoders() {
                                        media_weak_this_, DemuxerStream::VIDEO),
       base::Bind(&MediaCodecPlayer::OnStarvation, media_weak_this_,
                  DemuxerStream::VIDEO),
+      base::Bind(&MediaCodecPlayer::OnPrerollDone, media_weak_this_),
       base::Bind(&MediaCodecPlayer::OnStopDone, media_weak_this_),
       internal_error_cb_,
       base::Bind(&MediaCodecPlayer::OnTimeIntervalUpdate, media_weak_this_,