media/base/android/media_codec_audio_decoder.h - Issue 1254293003: MediaCodecPlayer implementation (stage 4 - preroll)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_codec_audio_decoder.h

Issue 1254293003: MediaCodecPlayer implementation (stage 4 - preroll) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mtplayer-browserseek

Patch Set: Addressed Matt's comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/base/android/java/src/org/chromium/media/MediaCodecBridge.java ('k') | media/base/android/media_codec_audio_decoder.cc » ('j') | media/base/android/media_codec_bridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_codec_audio_decoder.h

diff --git a/media/base/android/media_codec_audio_decoder.h b/media/base/android/media_codec_audio_decoder.h

index 53bb664f6018b833e4fa5f571c12051c8ad727c9..53aa8b3931adb70c00513585706289cf2edd9bba 100644

--- a/media/base/android/media_codec_audio_decoder.h

+++ b/media/base/android/media_codec_audio_decoder.h

@@ -31,6 +31,7 @@ class MediaCodecAudioDecoder : public MediaCodecDecoder {

bool HasStream() const override;

void SetDemuxerConfigs(const DemuxerConfigs& configs) override;

void Flush() override;

+ void ReleaseMediaCodec() override;

// Sets the volume of the audio output.

void SetVolume(double volume);

@@ -45,7 +46,7 @@ class MediaCodecAudioDecoder : public MediaCodecDecoder {

void OnOutputFormatChanged() override;

void Render(int buffer_index,

size_t size,

- bool render_output,

+ RenderMode render_mode,

base::TimeDelta pts,

bool eos_encountered) override;