Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: media/base/android/media_codec_bridge.h

Issue 1254293003: MediaCodecPlayer implementation (stage 4 - preroll) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mtplayer-browserseek
Patch Set: Addressed Matt's comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_codec_bridge.h
diff --git a/media/base/android/media_codec_bridge.h b/media/base/android/media_codec_bridge.h
index 8de5c4b24e0f33c6fb11fab661e2691a22175e09..00d06150ae76caf6ef0e6f3173154024a88d5a80 100644
--- a/media/base/android/media_codec_bridge.h
+++ b/media/base/android/media_codec_bridge.h
@@ -233,10 +233,15 @@ class AudioCodecBridge : public MediaCodecBridge {
int64 codec_delay_ns, int64 seek_preroll_ns,
bool play_audio, jobject media_crypto) WARN_UNUSED_RESULT;
- // Play the output buffer. This call must be called after
- // DequeueOutputBuffer() and before ReleaseOutputBuffer. Returns the playback
- // head position expressed in frames.
- int64 PlayOutputBuffer(int index, size_t size);
+ // Plays the output buffer right away or save for later playback if |postpone|
+ // is set to true. This call must be called after DequeueOutputBuffer() and
+ // before ReleaseOutputBuffer. The data is extracted from the output buffers
+ // using |index| and |size|. Returns the playback head position expressed
+ // in frames.
+ // When |postpone| is set to true, the next PlayOutputBuffer() should have
+ // postpone == false, and if will play two buffers: the postponed one and
wolenetz 2015/08/20 23:39:12 nit: s/if/it/
Tima Vaisburd 2015/08/21 20:18:24 Done.
+ // the one identified by |index|.
+ int64 PlayOutputBuffer(int index, size_t size, bool postpone = false);
// Set the volume of the audio output.
void SetVolume(double volume);

Powered by Google App Engine
This is Rietveld 408576698