Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1254243002: Remove Node.localName and Node.namespaceURI (Closed)

Created:
5 years, 4 months ago by HyungwookLee
Modified:
5 years, 2 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-html_chromium.org, vivekg, sof, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove Node.localName and Node.namespaceURI These are no longer on the Node interface in DOM: https://dom.spec.whatwg.org/#interface-node Node.namespaceURI and Node.localName are shadowed on Element and Attr, so in every case where the attributes on Node are accessed, they will return null. Removing them will instead make any access return undefined. This CL is based on http://crrev.com/753893002. BUG=504574 Committed: https://crrev.com/bda35b7099326aa2fd019473c1c21cea6806533f git-svn-id: svn://svn.chromium.org/blink/trunk@199576 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Fix layout test failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -92 lines) Patch
M LayoutTests/fast/dom/Node/initial-values-expected.txt View 2 chunks +16 lines, -16 lines 0 comments Download
M LayoutTests/fast/dom/Node/script-tests/initial-values.js View 4 chunks +16 lines, -18 lines 0 comments Download
M LayoutTests/http/tests/misc/createElementNamespace1.xml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/createElementNamespace1-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/createElementNamespace2.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/createElementNamespace2-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/createElementNamespace3.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/misc/createElementNamespace3-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Attr.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 2 chunks +15 lines, -17 lines 0 comments Download
M Source/core/dom/Node.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLStackItem.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/xml/XPathFunctions.cpp View 2 chunks +23 lines, -4 lines 0 comments Download
M Source/core/xml/XPathStep.cpp View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
HyungwookLee
PTAL.
5 years, 4 months ago (2015-07-27 12:51:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254243002/1
5 years, 4 months ago (2015-07-27 12:57:29 UTC) #4
philipj_slow
I've started a CQ dry run to see if any tests fail. I think at ...
5 years, 4 months ago (2015-07-27 12:57:53 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/71652)
5 years, 4 months ago (2015-07-27 14:06:15 UTC) #7
philipj_slow
As expected, you need to update these tests: webexposed/global-interface-listing.html virtual/stable/webexposed/global-interface-listing.html No other failures though, yay!
5 years, 4 months ago (2015-07-27 14:13:33 UTC) #8
philipj_slow
lgtm
5 years, 4 months ago (2015-07-27 14:23:33 UTC) #9
HyungwookLee
On 2015/07/27 14:13:33, philipj wrote: > As expected, you need to update these tests: > ...
5 years, 4 months ago (2015-07-28 08:17:20 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254243002/20001
5 years, 4 months ago (2015-07-28 09:53:20 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-28 11:09:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254243002/20001
5 years, 4 months ago (2015-07-28 11:10:05 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199576
5 years, 4 months ago (2015-07-28 11:12:51 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 11:50:43 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bda35b7099326aa2fd019473c1c21cea6806533f

Powered by Google App Engine
This is Rietveld 408576698