Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 1254243002: Remove Node.localName and Node.namespaceURI (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix layout test failure Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/parser/HTMLStackItem.h ('k') | Source/core/xml/XPathFunctions.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 1577 matching lines...) Expand 10 before | Expand all | Expand 10 after
1588 1588
1589 switch (node->nodeType()) { 1589 switch (node->nodeType()) {
1590 case Node::TEXT_NODE: 1590 case Node::TEXT_NODE:
1591 case Node::COMMENT_NODE: 1591 case Node::COMMENT_NODE:
1592 case Node::CDATA_SECTION_NODE: 1592 case Node::CDATA_SECTION_NODE:
1593 nodeValue = node->nodeValue(); 1593 nodeValue = node->nodeValue();
1594 if (nodeValue.length() > maxTextSize) 1594 if (nodeValue.length() > maxTextSize)
1595 nodeValue = nodeValue.left(maxTextSize) + ellipsisUChar; 1595 nodeValue = nodeValue.left(maxTextSize) + ellipsisUChar;
1596 break; 1596 break;
1597 case Node::ATTRIBUTE_NODE: 1597 case Node::ATTRIBUTE_NODE:
1598 case Node::DOCUMENT_FRAGMENT_NODE: 1598 localName = toAttr(node)->localName();
1599 case Node::DOCUMENT_NODE: 1599 break;
1600 case Node::ELEMENT_NODE: 1600 case Node::ELEMENT_NODE:
1601 localName = toElement(node)->localName();
1602 break;
1601 default: 1603 default:
1602 localName = node->localName();
1603 break; 1604 break;
1604 } 1605 }
1605 1606
1606 RefPtr<TypeBuilder::DOM::Node> value = TypeBuilder::DOM::Node::create() 1607 RefPtr<TypeBuilder::DOM::Node> value = TypeBuilder::DOM::Node::create()
1607 .setNodeId(id) 1608 .setNodeId(id)
1608 .setNodeType(static_cast<int>(node->nodeType())) 1609 .setNodeType(static_cast<int>(node->nodeType()))
1609 .setNodeName(node->nodeName()) 1610 .setNodeName(node->nodeName())
1610 .setLocalName(localName) 1611 .setLocalName(localName)
1611 .setNodeValue(nodeValue); 1612 .setNodeValue(nodeValue);
1612 1613
(...skipping 623 matching lines...) Expand 10 before | Expand all | Expand 10 after
2236 visitor->trace(m_searchResults); 2237 visitor->trace(m_searchResults);
2237 #endif 2238 #endif
2238 visitor->trace(m_hoveredNodeForInspectMode); 2239 visitor->trace(m_hoveredNodeForInspectMode);
2239 visitor->trace(m_history); 2240 visitor->trace(m_history);
2240 visitor->trace(m_domEditor); 2241 visitor->trace(m_domEditor);
2241 visitor->trace(m_listener); 2242 visitor->trace(m_listener);
2242 InspectorBaseAgent::trace(visitor); 2243 InspectorBaseAgent::trace(visitor);
2243 } 2244 }
2244 2245
2245 } // namespace blink 2246 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/html/parser/HTMLStackItem.h ('k') | Source/core/xml/XPathFunctions.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698