Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 125403006: Various QUIC cleanups to sync with internal code. (Closed)

Created:
6 years, 11 months ago by Ryan Hamilton
Modified:
6 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Various QUIC cleanups to sync with internal code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243462

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -224 lines) Patch
M net/quic/congestion_control/cubic.h View 2 chunks +1 line, -5 lines 0 comments Download
M net/quic/congestion_control/cubic.cc View 5 chunks +8 lines, -77 lines 0 comments Download
M net/quic/congestion_control/cubic_test.cc View 6 chunks +17 lines, -56 lines 0 comments Download
M net/quic/congestion_control/fix_rate_sender.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/congestion_control/hybrid_slow_start.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_bitrate_ramp_up.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_bitrate_ramp_up.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_bitrate_ramp_up_test.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_overuse_detector_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/inter_arrival_probe.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_probe_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/congestion_control/inter_arrival_sender.cc View 6 chunks +15 lines, -10 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_sender_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/congestion_control/leaky_bucket.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/congestion_control/pacing_sender.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/congestion_control/receive_algorithm_interface.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M net/quic/congestion_control/tcp_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_bandwidth.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_connection.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_connection.cc View 6 chunks +9 lines, -15 lines 0 comments Download
M net/quic/quic_end_to_end_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_framer.cc View 3 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_framer_test.cc View 6 chunks +17 lines, -12 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Hamilton
6 years, 11 months ago (2014-01-07 18:51:40 UTC) #1
ramant (doing other things)
Awesome. Many many thanks for making these changes. https://codereview.chromium.org/125403006/diff/1/net/quic/congestion_control/hybrid_slow_start.cc File net/quic/congestion_control/hybrid_slow_start.cc (right): https://codereview.chromium.org/125403006/diff/1/net/quic/congestion_control/hybrid_slow_start.cc#newcode93 net/quic/congestion_control/hybrid_slow_start.cc:93: kHybridStartDelayMaxThresholdUs); ...
6 years, 11 months ago (2014-01-07 19:20:40 UTC) #2
ramant (doing other things)
lgtm
6 years, 11 months ago (2014-01-07 19:24:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/125403006/310001
6 years, 11 months ago (2014-01-07 20:14:53 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=208740
6 years, 11 months ago (2014-01-07 23:56:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/125403006/310001
6 years, 11 months ago (2014-01-08 00:02:32 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 01:28:11 UTC) #7
Message was sent while issue was closed. 
Change committed as 243462

Powered by Google App Engine
This is Rietveld 408576698