Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: net/quic/quic_framer.cc

Issue 125403006: Various QUIC cleanups to sync with internal code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_end_to_end_unittest.cc ('k') | net/quic/quic_framer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_framer.cc
diff --git a/net/quic/quic_framer.cc b/net/quic/quic_framer.cc
index 3dd72b90d9340748f26f9e2e5a7a7e35143cc511..9d15c3c5130a5d2a18ab3424579adc8bb823b195 100644
--- a/net/quic/quic_framer.cc
+++ b/net/quic/quic_framer.cc
@@ -18,6 +18,8 @@ using std::min;
using std::numeric_limits;
using std::string;
+bool FLAGS_quic_allow_oversized_packets_for_test = false;
+
namespace net {
namespace {
@@ -266,6 +268,8 @@ size_t QuicFramer::GetSerializedFrameLength(
// Note that we may not use every byte of the writer in this case.
DVLOG(1) << "Truncating large frame";
return free_bytes;
+ } else if (!FLAGS_quic_allow_oversized_packets_for_test) {
+ return 0;
}
}
return frame_len;
@@ -1729,7 +1733,7 @@ bool QuicFramer::AppendPacketSequenceNumber(
packet_sequence_number & k6ByteSequenceNumberMask);
break;
default:
- NOTREACHED() << "sequence_number_length: " << sequence_number_length;
+ DCHECK(false) << "sequence_number_length: " << sequence_number_length;
return false;
}
}
« no previous file with comments | « net/quic/quic_end_to_end_unittest.cc ('k') | net/quic/quic_framer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698