Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1254003005: Fix master zero-value build property passing. (Closed)

Created:
5 years, 4 months ago by dnj
Modified:
5 years, 4 months ago
Reviewers:
dnj (Google), luqui, hinoka
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Fix master zero-value build property passing. BUG=chromium:516091 TEST=local - Started master locally, triggered with build number of 0, confirmed that JSON value is now 0 instead of "". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296197

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M scripts/master/factory/commands.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dnj (Google)
PTAL
5 years, 4 months ago (2015-08-01 01:31:48 UTC) #2
hinoka
lgtm, presumably we don't render anything that actually wants to be "0"?
5 years, 4 months ago (2015-08-03 11:37:29 UTC) #3
dnj (Google)
On 2015/08/03 11:37:29, hinoka wrote: > lgtm, presumably we don't render anything that actually wants ...
5 years, 4 months ago (2015-08-03 16:01:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254003005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254003005/1
5 years, 4 months ago (2015-08-03 16:26:26 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 16:29:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296197

Powered by Google App Engine
This is Rietveld 408576698