scripts/master/factory/commands.py - Issue 1254003005: Fix master zero-value build property passing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/master/factory/commands.py

Issue 1254003005: Fix master zero-value build property passing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/master/factory/commands.py

diff --git a/scripts/master/factory/commands.py b/scripts/master/factory/commands.py

index 99e6a6e8b65d7bad1c1f74788074dc02caa2c575..3304482003a2fde87a9ba5c97351cdc1909dbf35 100644

--- a/scripts/master/factory/commands.py

+++ b/scripts/master/factory/commands.py

@@ -216,7 +216,7 @@ class WithJsonProperties(WithProperties):

# asDict returns key -> (value, source), so get the values, and convert

# empty values to blank strings.

for k in ret:

- ret[k] = ret[k][0] or ''

+ ret[k] = ret[k][0] if ret[k][0] is not None else ''

for k, v in self.lambda_subs.iteritems():

ret[k] = v(build)

return self.fmtstring % self.transform(ret)

« no previous file with comments | « no previous file | no next file » | no next file with comments »