Componentize enhanced_bookmark_features.{h,cc}.

Componentize enhanced_bookmark_features.{h,cc}.

Enhanced bookmarks and the DOM distiller are (or will be) used on
iOS and android. Move the function checking whether the features
are enabled into the respective component to allow sharing the code.

Move IsEnhancedBookmarksEnabled() function to the enhanced_bookmarks
component with supporting switches.

Move IsEnableDomDistillerSet() and IsEnableSyncArticlesSet() functions
to the dom_distiller component with supporting switches.

BUG=359565
Committed: https://crrev.com/0f2ef35a2de53103f42a7ab62ccc07aa34481e41
Cr-Commit-Position: refs/heads/master@{#340526}

[sdefresne, 2015-07-24 15:53:31]

Patchset #1 (id:1) has been deleted

[sdefresne, 2015-07-24 16:02:58]

sdefresne@chromium.org changed reviewers:
+ cjhopman@chromium.org, noyau@chromium.org, sky@chromium.org

[sdefresne, 2015-07-24 16:02:58]

Please each take a look at the following files

noyau:
- components/enhanced_bookmarks

cjhopman:
- components/dom_distiller

sky:
- chrome/browser/android/bookmarks/bookmarks_bridge.cc
- chrome/browser/bookmarks/enhanced_bookmarks_features.cc
- chrome/browser/bookmarks/enhanced_bookmarks_features.h
- chrome/browser/sync/profile_sync_components_factory_impl.cc
- chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
- chrome/common/BUILD.gn
- chrome/common/DEPS
- chrome/common_constants.gyp

Thank you!

[sdefresne, 2015-07-24 16:03:35]

noyau: please also look at
- ios

[noyau (Ping after 24h), 2015-07-24 16:09:17]

lgtm (once the bug we discussed offline is fixed(

[sdefresne, 2015-07-24 16:11:20]

On 2015/07/24 at 16:09:17, noyau wrote:
> lgtm (once the bug we discussed offline is fixed(

Thanks (fixed the issue, but the bots are busted for everyone, will send to the
bots later).

[tfarina, 2015-07-24 18:00:44]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2015-07-24 18:00:45]

Is this going to be used by ios? Hence this is being componentized? If yes,
could you add that information to the CL description? If it is something else,
could you also note that in the description, so future readers can know why this
was being done?

[sky, 2015-07-24 20:26:45]

https://codereview.chromium.org/1253953002/diff/40001/chrome/common/BUILD.gn
File chrome/common/BUILD.gn (right):

https://codereview.chromium.org/1253953002/diff/40001/chrome/common/BUILD.gn#...
chrome/common/BUILD.gn:307: "//components/dom_distiller/core",
This code ends up linked into the renderer. It doesn't seem like we want
bookmarks there. Maybe I'm missing something?

[sdefresne, 2015-07-25 19:17:38]

On 2015/07/24 at 18:00:45, tfarina wrote:
> Is this going to be used by ios? Hence this is being componentized? If yes,
could you add that information to the CL description? If it is something else,
could you also note that in the description, so future readers can know why this
was being done?

Yes this is componentized because it is used on iOS. I've updated the
description to make this clear.

[sdefresne, 2015-07-25 19:17:57]

sky: please take another look.

https://codereview.chromium.org/1253953002/diff/40001/chrome/common/BUILD.gn
File chrome/common/BUILD.gn (right):

https://codereview.chromium.org/1253953002/diff/40001/chrome/common/BUILD.gn#...
chrome/common/BUILD.gn:307: "//components/dom_distiller/core",
On 2015/07/24 at 20:26:45, sky wrote:
> This code ends up linked into the renderer. It doesn't seem like we want
bookmarks there. Maybe I'm missing something?

Removed. Thank you for pointing this.

[sky, 2015-07-27 15:27:43]

LGTM

[sdefresne, 2015-07-27 15:51:40]

cjhopman: ping?

[cjhopman, 2015-07-27 18:22:21]

lgtm

[sdefresne, 2015-07-27 18:36:47]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-07-27 18:36:47]

The patchset sent to the CQ was uploaded after l-g-t-m from noyau@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1253953002/#ps80001
(title: "Revert change in //chrome/common/DEPS that broke checkdeps")

[commit-bot: I haz the power, 2015-07-27 18:37:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1253953002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1253953002/80001

[commit-bot: I haz the power, 2015-07-27 19:18:07]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-07-27 19:19:14]

Patchset 4 (id:??) landed as
https://crrev.com/0f2ef35a2de53103f42a7ab62ccc07aa34481e41
Cr-Commit-Position: refs/heads/master@{#340526}