ios/chrome/browser/experimental_flags.mm - Issue 1253953002: Componentize enhanced_bookmark_features.{h,cc}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/experimental_flags.mm

Issue 1253953002: Componentize enhanced_bookmark_features.{h,cc}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert change in //chrome/common/DEPS that broke checkdeps Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/experimental_flags.mm

diff --git a/ios/chrome/browser/experimental_flags.mm b/ios/chrome/browser/experimental_flags.mm

index a44cfeb5dcd26077c996f7246d0fe2c6e9ac18f7..ecf130c0d3c109971544d1675584a840607d79c4 100644

--- a/ios/chrome/browser/experimental_flags.mm

+++ b/ios/chrome/browser/experimental_flags.mm

@@ -15,9 +15,9 @@

#include "base/metrics/field_trial.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_util.h"

+#include "components/enhanced_bookmarks/enhanced_bookmark_features.h"

#include "components/variations/variations_associated_data.h"

#include "ios/chrome/browser/chrome_switches.h"

-#include "ios/public/provider/chrome/browser/chrome_browser_provider.h"

#include "ios/web/public/web_view_creation_util.h"

namespace {

@@ -35,7 +35,7 @@ bool IsAlertOnBackgroundUploadEnabled() {

}

bool IsBookmarkCollectionEnabled() {

- return ios::GetChromeBrowserProvider()->IsBookmarkCollectionEnabled();

+ return enhanced_bookmarks::IsEnhancedBookmarksEnabled();

}

bool IsBookmarkImageFetchingOnVisitEnabled() {