Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1253843002: Disable ProcessSingletonTest.StartupRaceCondition (Closed)

Created:
5 years, 5 months ago by pval...(no longer on Chromium)
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ProcessSingletonTest.StartupRaceCondition This code rotted away as a result of not calling InProcessBrowserTest::SetUp and therefore never executing. See http://crbug.com/510649 for the high-level problem that caused this. BUG=513534 Committed: https://crrev.com/6ef1472d9d2941972f423561beb7a2106974d5fd Cr-Commit-Position: refs/heads/master@{#340751}

Patch Set 1 #

Patch Set 2 : Disable the test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M chrome/browser/process_singleton_browsertest.cc View 1 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253843002/1
5 years, 5 months ago (2015-07-24 00:24:45 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/81649) linux_chromium_gn_chromeos_rel on ...
5 years, 5 months ago (2015-07-24 00:31:18 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253843002/1
5 years, 5 months ago (2015-07-24 03:55:59 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/95284) android_chromium_gn_compile_rel on ...
5 years, 5 months ago (2015-07-24 04:06:41 UTC) #8
pval...(no longer on Chromium)
Here's another test case affected by http://crbug.com/510649 I tried to re-enable it in patchset 1 ...
5 years, 5 months ago (2015-07-24 17:29:46 UTC) #10
pval...(no longer on Chromium)
On 2015/07/24 17:29:46, pvalenzuela wrote: > Here's another test case affected by http://crbug.com/510649 > > ...
5 years, 4 months ago (2015-07-28 16:57:14 UTC) #11
sky
LGTM
5 years, 4 months ago (2015-07-28 19:03:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253843002/20001
5 years, 4 months ago (2015-07-28 19:24:15 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-28 20:02:48 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 20:03:20 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ef1472d9d2941972f423561beb7a2106974d5fd
Cr-Commit-Position: refs/heads/master@{#340751}

Powered by Google App Engine
This is Rietveld 408576698