Disable ProcessSingletonTest.StartupRaceCondition

chrome/browser/process_singleton_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This test validates that the ProcessSingleton class properly makes sure
 // that there is only one main browser process.
 //
 // It is currently compiled and run on Windows and Posix(non-Mac) platforms.
 // Mac uses system services and ProcessSingletonMac is a noop.  (Maybe it still
 // makes sense to test that the system services are giving the behavior we
@@ skipping 120 matching lines @@
 class ProcessSingletonTest : public InProcessBrowserTest {
  public:
   ProcessSingletonTest()
       // We use a manual reset so that all threads wake up at once when signaled
       // and thus we must manually reset it for each attempt.
       : threads_waker_(true /* manual */, false /* signaled */) {
     EXPECT_TRUE(temp_profile_dir_.CreateUniqueTempDir());
   }
 
   void SetUp() override {
+    InProcessBrowserTest::SetUp();
     // Start the threads and create the starters.
     for (size_t i = 0; i < kNbThreads; ++i) {
       chrome_starter_threads_[i].reset(new base::Thread("ChromeStarter"));
       ASSERT_TRUE(chrome_starter_threads_[i]->Start());
       chrome_starters_[i] = new ChromeStarter(
           TestTimeouts::action_max_timeout(), temp_profile_dir_.path());
     }
   }
 
   void TearDown() override {
@@ skipping 58 matching lines @@
 
   // The event that will get all threads to wake up simultaneously and try
   // to start a chrome process at the same time.
   base::WaitableEvent threads_waker_;
 
   // We don't want to use the default profile, but can't use UITest's since we
   // don't use UITest::LaunchBrowser.
   base::ScopedTempDir temp_profile_dir_;
 };
 
-#if defined(OS_LINUX) && defined(TOOLKIT_VIEWS)
-// http://crbug.com/58219
-#define MAYBE_StartupRaceCondition DISABLED_StartupRaceCondition
-#else
-#define MAYBE_StartupRaceCondition StartupRaceCondition
-#endif
-IN_PROC_BROWSER_TEST_F(ProcessSingletonTest, MAYBE_StartupRaceCondition) {
+// Disabled on all platforms after code rot due to http://crbug.com/513534.
+// Originally disabled on some platforms due to http://crbug.com/58219.
+IN_PROC_BROWSER_TEST_F(ProcessSingletonTest, DISABLED_StartupRaceCondition) {
   // We use this to stop the attempts loop on the first failure.
   bool failed = false;
   for (size_t attempt = 0; attempt < kNbAttempts && !failed; ++attempt) {
     SCOPED_TRACE(testing::Message() << "Attempt: " << attempt << ".");
     // We use a single event to get all threads to do the AppLaunch at the same
     // time...
     threads_waker_.Reset();
 
     // Test both with and without the first-run dialog, since they exercise
     // different paths.
@@ skipping 76 matching lines @@
     // "There can be only one!" :-)
     ASSERT_EQ(static_cast<size_t>(1), pending_starters.size());
     size_t last_index = pending_starters.front();
     pending_starters.clear();
     if (chrome_starters_[last_index]->process_.IsValid()) {
       KillProcessTree(chrome_starters_[last_index]->process_);
       chrome_starters_[last_index]->done_event_.Wait();
     }
   }
 }