Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4669)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkRow.java

Issue 1253783002: Refactor the way enhanced bookmark gets large icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use mDelegate.getModel Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFolderRow.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkRow.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkRow.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkRow.java
index b054d50d1ab4a4ba5af7a161c1275efdea6e52be..e36464e4f2b0602e6aab272b4531a53a884b7c94 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkRow.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkRow.java
@@ -51,11 +51,16 @@ abstract class EnhancedBookmarkRow extends FrameLayout implements EnhancedBookma
super(context, attrs);
}
- void setBookmarkId(BookmarkId bookmarkId) {
+ /**
+ * Updates this row for the given {@link BookmarkId}.
+ * @return The {@link BookmarkItem} corresponding the given {@link BookmarkId}.
+ */
+ BookmarkItem setBookmarkId(BookmarkId bookmarkId) {
mBookmarkId = bookmarkId;
BookmarkItem bookmarkItem = mDelegate.getModel().getBookmarkById(bookmarkId);
mMoreIcon.setVisibility(bookmarkItem.isEditable() ? VISIBLE : GONE);
setChecked(mDelegate.isBookmarkSelected(bookmarkId));
+ return bookmarkItem;
}
/**
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFolderRow.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698