chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFolderRow.java - Issue 1253783002: Refactor the way enhanced bookmark gets large icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFolderRow.java

Issue 1253783002: Refactor the way enhanced bookmark gets large icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use mDelegate.getModel Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkBookmarkRow.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkRow.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFolderRow.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFolderRow.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFolderRow.java

index f317bb42fc51bdbc2a39e3872a726353f312b5b4..724daa622e21ee4a0604ad55e6123d800059522b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFolderRow.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFolderRow.java

@@ -8,6 +8,7 @@ import android.content.Context;

import android.util.AttributeSet;

import org.chromium.chrome.R;

+import org.chromium.chrome.browser.BookmarksBridge.BookmarkItem;

import org.chromium.chrome.browser.widget.TintedDrawable;

import org.chromium.components.bookmarks.BookmarkId;

@@ -38,8 +39,9 @@ public class EnhancedBookmarkFolderRow extends EnhancedBookmarkRow {

}

@Override

- public void setBookmarkId(BookmarkId bookmarkId) {

- super.setBookmarkId(bookmarkId);

- mTitleView.setText(mDelegate.getModel().getBookmarkTitle(bookmarkId));

+ BookmarkItem setBookmarkId(BookmarkId bookmarkId) {

+ BookmarkItem item = super.setBookmarkId(bookmarkId);

+ mTitleView.setText(item.getTitle());

+ return item;

}