media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java - Issue 1253183006: Web MIDI: Android Chrome is stuck if connected USB devices are not MIDI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java

Issue 1253183006: Web MIDI: Android Chrome is stuck if connected USB devices are not MIDI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java

diff --git a/media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java b/media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java

index e0033325e28f428d35dc1f69da386bc6ae30dfac..26227e89cd6d9ae2c86b37a1c55dfa651cffc0b0 100644

--- a/media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java

+++ b/media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java

@@ -127,7 +127,7 @@ class UsbMidiDeviceFactoryAndroid {

for (UsbDevice device : devices.values()) {

requestDevicePermissionIfNecessary(context, device);

}

- return true;

+ return !mRequestedDevices.isEmpty();

}

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »