Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 1253053005: Dont reset unusedScrollDelta for nonScrollable Axes. (Closed)

Created:
5 years, 4 months ago by MuVen
Modified:
5 years, 2 months ago
Reviewers:
pdr., majidvp
CC:
blink-reviews, bokan, jdduke (slow)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Dont reset unusedScrollDelta for nonScrollable Axes. Dont reset unusedScrollDelta for nonScrollable axes at renderer. As resetting overscroll for unscrollable axes is done at browser. So pass on the unusedScrollDelta calculated at renderer as is. BUG=506193 Committed: https://crrev.com/8e7ded482206020d3894ab32f6b709fbe2f45f68 git-svn-id: svn://svn.chromium.org/blink/trunk@199594 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : removed relavant tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -53 lines) Patch
M Source/core/input/EventHandler.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
MuVen
PTAL.
5 years, 4 months ago (2015-07-28 08:43:11 UTC) #2
majidvp
On 2015/07/28 08:43:11, MuVen wrote: > PTAL. This is fine but I think you need ...
5 years, 4 months ago (2015-07-28 11:36:13 UTC) #3
MuVen
On 2015/07/28 11:36:13, majidvp wrote: > On 2015/07/28 08:43:11, MuVen wrote: > > PTAL. > ...
5 years, 4 months ago (2015-07-28 11:38:33 UTC) #4
MuVen
PTAL.
5 years, 4 months ago (2015-07-28 12:07:52 UTC) #5
majidvp
On 2015/07/28 12:07:52, MuVen wrote: > PTAL. lgtm with nit: The description does not need ...
5 years, 4 months ago (2015-07-28 14:03:02 UTC) #6
MuVen
pdr@ for owners stamp.
5 years, 4 months ago (2015-07-28 15:32:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253053005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253053005/20001
5 years, 4 months ago (2015-07-28 15:32:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/38601)
5 years, 4 months ago (2015-07-28 15:37:15 UTC) #12
pdr.
lgtm
5 years, 4 months ago (2015-07-28 18:29:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253053005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253053005/20001
5 years, 4 months ago (2015-07-28 18:30:06 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199594
5 years, 4 months ago (2015-07-28 18:33:03 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 11:51:16 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e7ded482206020d3894ab32f6b709fbe2f45f68

Powered by Google App Engine
This is Rietveld 408576698