Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2252)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 1253053005: Dont reset unusedScrollDelta for nonScrollable Axes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: removed relavant tests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/input/EventHandler.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index c1ba93fa49bfc12e343b7b633364ed1a0c36fb83..0c4b139119f85116b1d708a9974e1d892a242fe8 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -7842,52 +7842,6 @@ TEST_F(WebFrameOverscrollTest, RootLayerOverscrolledOnInnerIFrameOverScroll)
Mock::VerifyAndClearExpectations(&client);
}
-TEST_F(WebFrameOverscrollTest, NoOverscrollOnNonScrollableaxes)
-{
- OverscrollWebViewClient client;
- registerMockedHttpURLLoad("overscroll/no-overscroll-on-nonscrollable-axes.html");
- FrameTestHelpers::WebViewHelper webViewHelper;
- webViewHelper.initializeAndLoad(m_baseURL + "overscroll/no-overscroll-on-nonscrollable-axes.html", true, 0, &client, configureAndroid);
-
- // Overscroll is not reported in all the directions.
- ScrollBegin(&webViewHelper);
- EXPECT_CALL(client, didOverscroll(_, _, _, _)).Times(0);
- ScrollUpdate(&webViewHelper, 0, -1);
- Mock::VerifyAndClearExpectations(&client);
-
- EXPECT_CALL(client, didOverscroll(_, _, _, _)).Times(0);
- ScrollUpdate(&webViewHelper, 0, 1);
- Mock::VerifyAndClearExpectations(&client);
-
- EXPECT_CALL(client, didOverscroll(_, _, _, _)).Times(0);
- ScrollUpdate(&webViewHelper, 1, 0);
- Mock::VerifyAndClearExpectations(&client);
-
- EXPECT_CALL(client, didOverscroll(_, _, _, _)).Times(0);
- ScrollUpdate(&webViewHelper, -1, 0);
- Mock::VerifyAndClearExpectations(&client);
-
- EXPECT_CALL(client, didOverscroll(_, _, _, _)).Times(0);
- ScrollUpdate(&webViewHelper, 1, 1);
- Mock::VerifyAndClearExpectations(&client);
-
- EXPECT_CALL(client, didOverscroll(_, _, _, _)).Times(0);
- ScrollUpdate(&webViewHelper, -1, 1);
- Mock::VerifyAndClearExpectations(&client);
-
- EXPECT_CALL(client, didOverscroll(_, _, _, _)).Times(0);
- ScrollUpdate(&webViewHelper, 1, -1);
- Mock::VerifyAndClearExpectations(&client);
-
- EXPECT_CALL(client, didOverscroll(_, _, _, _)).Times(0);
- ScrollUpdate(&webViewHelper, -1, -1);
- Mock::VerifyAndClearExpectations(&client);
-
- EXPECT_CALL(client, didOverscroll(_, _, _, _)).Times(0);
- ScrollEnd(&webViewHelper);
- Mock::VerifyAndClearExpectations(&client);
-}
-
TEST_F(WebFrameOverscrollTest, ScaledPageRootLayerOverscrolled)
{
OverscrollWebViewClient client;
« no previous file with comments | « Source/core/input/EventHandler.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698