Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1252973007: Retire unused memcheck suppressions. HttpServerPropertiesManager code (Closed)

Created:
5 years, 4 months ago by ramant (doing other things)
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Retire unused memcheck suppressions. HttpServerPropertiesManager code has changed a lot recently (we update/persist only if things change etc). Retire from tools/valgrind/memcheck/suppressions.txt any bug suppressions that we have no known occurrences for in http://chromium-build-logs.appspot.com/suppression_query?suppression_query=HttpServerPropertiesManager BUG=288804 R=thestig@chromium.org Committed: https://crrev.com/1d09c9949ff5ded7bc4bead73646f7010b679e94 Cr-Commit-Position: refs/heads/master@{#341637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
Hi Lei, HttpServerPropertiesManager code has changed a lot. Would like to find out the latest ...
5 years, 4 months ago (2015-08-03 23:02:10 UTC) #1
Lei Zhang
lgtm
5 years, 4 months ago (2015-08-03 23:07:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252973007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252973007/1
5 years, 4 months ago (2015-08-03 23:08:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 23:14:22 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 23:14:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d09c9949ff5ded7bc4bead73646f7010b679e94
Cr-Commit-Position: refs/heads/master@{#341637}

Powered by Google App Engine
This is Rietveld 408576698