Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 description("Test paint-order.") | 1 description("Test paint-order.") |
| 2 | 2 |
| 3 if (window.testRunner) | 3 if (window.testRunner) |
| 4 testRunner.dumpAsText(); | 4 testRunner.dumpAsText(); |
| 5 createSVGTestCase(); | 5 createSVGTestCase(); |
| 6 | 6 |
| 7 var text = createSVGElement("text"); | 7 var text = createSVGElement("text"); |
| 8 text.setAttribute("id", "text"); | 8 text.setAttribute("id", "text"); |
| 9 text.setAttribute("x", "100px"); | 9 text.setAttribute("x", "100px"); |
| 10 text.setAttribute("y", "100px"); | 10 text.setAttribute("y", "100px"); |
| (...skipping 12 matching lines...) Expand all Loading... | |
| 23 // Reset paint-order. | 23 // Reset paint-order. |
| 24 text.removeAttribute("paint-order"); | 24 text.removeAttribute("paint-order"); |
| 25 | 25 |
| 26 // Run test | 26 // Run test |
| 27 text.setAttribute("paint-order", valueString); | 27 text.setAttribute("paint-order", valueString); |
| 28 shouldBeEqualToString("getComputedStyle(text).paintOrder", expectedValue); | 28 shouldBeEqualToString("getComputedStyle(text).paintOrder", expectedValue); |
| 29 } | 29 } |
| 30 | 30 |
| 31 debug(""); | 31 debug(""); |
| 32 debug("Test pre-normalized correct variants of 'paint-order'"); | 32 debug("Test pre-normalized correct variants of 'paint-order'"); |
| 33 test("fill stroke markers", "fill stroke markers"); | 33 test("fill stroke markers", "fill"); |
|
pdr.
2015/07/29 05:20:50
Is this change correct?
This seems to make us mat
Shanmuga Pandi
2015/07/29 06:55:04
Is it ok to change the code as like old approach.
| |
| 34 test("fill markers stroke", "fill markers stroke"); | 34 test("fill markers stroke", "fill markers"); |
| 35 test("stroke fill markers", "stroke fill markers"); | 35 test("stroke fill markers", "stroke"); |
| 36 test("stroke markers fill", "stroke markers fill"); | 36 test("stroke markers fill", "stroke markers"); |
| 37 test("markers stroke fill", "markers stroke fill"); | 37 test("markers stroke fill", "markers stroke"); |
| 38 test("markers fill stroke", "markers fill stroke"); | 38 test("markers fill stroke", "markers"); |
| 39 | 39 |
| 40 debug(""); | 40 debug(""); |
| 41 debug("Test correct single keyword value of 'paint-order'"); | 41 debug("Test correct single keyword value of 'paint-order'"); |
| 42 test("normal", "fill stroke markers"); | 42 test("normal", "normal"); |
| 43 test("fill", "fill stroke markers"); | 43 test("fill", "fill"); |
| 44 test("stroke", "stroke fill markers"); | 44 test("stroke", "stroke"); |
| 45 test("markers", "markers fill stroke"); | 45 test("markers", "markers"); |
| 46 | 46 |
| 47 debug(""); | 47 debug(""); |
| 48 debug("Test correct dual keyword values of 'paint-order'"); | 48 debug("Test correct dual keyword values of 'paint-order'"); |
| 49 test("fill stroke", "fill stroke markers"); | 49 test("fill stroke", "fill"); |
| 50 test("fill markers", "fill markers stroke"); | 50 test("fill markers", "fill markers"); |
| 51 test("stroke fill", "stroke fill markers"); | 51 test("stroke fill", "stroke"); |
| 52 test("stroke markers", "stroke markers fill"); | 52 test("stroke markers", "stroke markers"); |
| 53 test("markers fill", "markers fill stroke"); | 53 test("markers fill", "markers"); |
| 54 test("markers stroke", "markers stroke fill"); | 54 test("markers stroke", "markers stroke"); |
| 55 | 55 |
| 56 debug(""); | 56 debug(""); |
| 57 debug("Test invalid values of 'paint-order'"); | 57 debug("Test invalid values of 'paint-order'"); |
| 58 test("foo", "fill stroke markers"); | 58 test("foo", "normal"); |
| 59 test("fill foo", "fill stroke markers"); | 59 test("fill foo", "normal"); |
| 60 test("stroke foo", "fill stroke markers"); | 60 test("stroke foo", "normal"); |
| 61 test("markers foo", "fill stroke markers"); | 61 test("markers foo", "normal"); |
| 62 test("normal foo", "fill stroke markers"); | 62 test("normal foo", "normal"); |
| 63 test("fill markers stroke foo", "fill stroke markers"); | 63 test("fill markers stroke foo", "normal"); |
| 64 | 64 |
| 65 debug(""); | 65 debug(""); |
| 66 debug("Test pre-normalized correct variants of 'paint-order' (presentation attri bute)"); | 66 debug("Test pre-normalized correct variants of 'paint-order' (presentation attri bute)"); |
| 67 test_attr("fill stroke markers", "fill stroke markers"); | 67 test_attr("fill stroke markers", "fill"); |
| 68 test_attr("fill markers stroke", "fill markers stroke"); | 68 test_attr("fill markers stroke", "fill markers"); |
| 69 test_attr("stroke fill markers", "stroke fill markers"); | 69 test_attr("stroke fill markers", "stroke"); |
| 70 test_attr("stroke markers fill", "stroke markers fill"); | 70 test_attr("stroke markers fill", "stroke markers"); |
| 71 test_attr("markers stroke fill", "markers stroke fill"); | 71 test_attr("markers stroke fill", "markers stroke"); |
| 72 test_attr("markers fill stroke", "markers fill stroke"); | 72 test_attr("markers fill stroke", "markers"); |
| 73 | 73 |
| 74 debug(""); | 74 debug(""); |
| 75 debug("Test correct single keyword value of 'paint-order' (presentation attribut e)"); | 75 debug("Test correct single keyword value of 'paint-order' (presentation attribut e)"); |
| 76 test_attr("normal", "fill stroke markers"); | 76 test_attr("normal", "normal"); |
| 77 test_attr("fill", "fill stroke markers"); | 77 test_attr("fill", "fill"); |
| 78 test_attr("stroke", "stroke fill markers"); | 78 test_attr("stroke", "stroke"); |
| 79 test_attr("markers", "markers fill stroke"); | 79 test_attr("markers", "markers"); |
| 80 | 80 |
| 81 debug(""); | 81 debug(""); |
| 82 debug("Test correct dual keyword values of 'paint-order' (presentation attribute )"); | 82 debug("Test correct dual keyword values of 'paint-order' (presentation attribute )"); |
| 83 test_attr("fill stroke", "fill stroke markers"); | 83 test_attr("fill stroke", "fill"); |
| 84 test_attr("fill markers", "fill markers stroke"); | 84 test_attr("fill markers", "fill markers"); |
| 85 test_attr("stroke fill", "stroke fill markers"); | 85 test_attr("stroke fill", "stroke"); |
| 86 test_attr("stroke markers", "stroke markers fill"); | 86 test_attr("stroke markers", "stroke markers"); |
| 87 test_attr("markers fill", "markers fill stroke"); | 87 test_attr("markers fill", "markers"); |
| 88 test_attr("markers stroke", "markers stroke fill"); | 88 test_attr("markers stroke", "markers stroke"); |
| 89 | 89 |
| 90 debug(""); | 90 debug(""); |
| 91 debug("Test invalid values of 'paint-order' (presentation attribute)"); | 91 debug("Test invalid values of 'paint-order' (presentation attribute)"); |
| 92 test_attr("foo", "fill stroke markers"); | 92 test_attr("foo", "normal"); |
| 93 test_attr("fill foo", "fill stroke markers"); | 93 test_attr("fill foo", "normal"); |
| 94 test_attr("stroke foo", "fill stroke markers"); | 94 test_attr("stroke foo", "normal"); |
| 95 test_attr("markers foo", "fill stroke markers"); | 95 test_attr("markers foo", "normal"); |
| 96 test_attr("normal foo", "fill stroke markers"); | 96 test_attr("normal foo", "normal"); |
| 97 test_attr("fill markers stroke foo", "fill stroke markers"); | 97 test_attr("fill markers stroke foo", "normal"); |
| 98 | 98 |
| 99 var successfullyParsed = true; | 99 var successfullyParsed = true; |
| 100 | 100 |
| 101 completeTest(); | 101 completeTest(); |
| OLD | NEW |