Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: LayoutTests/svg/css/script-tests/svg-paint-order.js

Issue 1252933003: Shrink SVG paint-order to take less bits (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/svg/css/script-tests/svg-paint-order.js
diff --git a/LayoutTests/svg/css/script-tests/svg-paint-order.js b/LayoutTests/svg/css/script-tests/svg-paint-order.js
index d0f70ed70c64c3dda2f6d880eeeae09582abc408..c401e5cb9cf28387048253b05e2b870bc46c39ef 100644
--- a/LayoutTests/svg/css/script-tests/svg-paint-order.js
+++ b/LayoutTests/svg/css/script-tests/svg-paint-order.js
@@ -30,71 +30,71 @@ function test_attr(valueString, expectedValue) {
debug("");
debug("Test pre-normalized correct variants of 'paint-order'");
-test("fill stroke markers", "fill stroke markers");
-test("fill markers stroke", "fill markers stroke");
-test("stroke fill markers", "stroke fill markers");
-test("stroke markers fill", "stroke markers fill");
-test("markers stroke fill", "markers stroke fill");
-test("markers fill stroke", "markers fill stroke");
+test("fill stroke markers", "fill");
pdr. 2015/07/29 05:20:50 Is this change correct? This seems to make us mat
Shanmuga Pandi 2015/07/29 06:55:04 Is it ok to change the code as like old approach.
+test("fill markers stroke", "fill markers");
+test("stroke fill markers", "stroke");
+test("stroke markers fill", "stroke markers");
+test("markers stroke fill", "markers stroke");
+test("markers fill stroke", "markers");
debug("");
debug("Test correct single keyword value of 'paint-order'");
-test("normal", "fill stroke markers");
-test("fill", "fill stroke markers");
-test("stroke", "stroke fill markers");
-test("markers", "markers fill stroke");
+test("normal", "normal");
+test("fill", "fill");
+test("stroke", "stroke");
+test("markers", "markers");
debug("");
debug("Test correct dual keyword values of 'paint-order'");
-test("fill stroke", "fill stroke markers");
-test("fill markers", "fill markers stroke");
-test("stroke fill", "stroke fill markers");
-test("stroke markers", "stroke markers fill");
-test("markers fill", "markers fill stroke");
-test("markers stroke", "markers stroke fill");
+test("fill stroke", "fill");
+test("fill markers", "fill markers");
+test("stroke fill", "stroke");
+test("stroke markers", "stroke markers");
+test("markers fill", "markers");
+test("markers stroke", "markers stroke");
debug("");
debug("Test invalid values of 'paint-order'");
-test("foo", "fill stroke markers");
-test("fill foo", "fill stroke markers");
-test("stroke foo", "fill stroke markers");
-test("markers foo", "fill stroke markers");
-test("normal foo", "fill stroke markers");
-test("fill markers stroke foo", "fill stroke markers");
+test("foo", "normal");
+test("fill foo", "normal");
+test("stroke foo", "normal");
+test("markers foo", "normal");
+test("normal foo", "normal");
+test("fill markers stroke foo", "normal");
debug("");
debug("Test pre-normalized correct variants of 'paint-order' (presentation attribute)");
-test_attr("fill stroke markers", "fill stroke markers");
-test_attr("fill markers stroke", "fill markers stroke");
-test_attr("stroke fill markers", "stroke fill markers");
-test_attr("stroke markers fill", "stroke markers fill");
-test_attr("markers stroke fill", "markers stroke fill");
-test_attr("markers fill stroke", "markers fill stroke");
+test_attr("fill stroke markers", "fill");
+test_attr("fill markers stroke", "fill markers");
+test_attr("stroke fill markers", "stroke");
+test_attr("stroke markers fill", "stroke markers");
+test_attr("markers stroke fill", "markers stroke");
+test_attr("markers fill stroke", "markers");
debug("");
debug("Test correct single keyword value of 'paint-order' (presentation attribute)");
-test_attr("normal", "fill stroke markers");
-test_attr("fill", "fill stroke markers");
-test_attr("stroke", "stroke fill markers");
-test_attr("markers", "markers fill stroke");
+test_attr("normal", "normal");
+test_attr("fill", "fill");
+test_attr("stroke", "stroke");
+test_attr("markers", "markers");
debug("");
debug("Test correct dual keyword values of 'paint-order' (presentation attribute)");
-test_attr("fill stroke", "fill stroke markers");
-test_attr("fill markers", "fill markers stroke");
-test_attr("stroke fill", "stroke fill markers");
-test_attr("stroke markers", "stroke markers fill");
-test_attr("markers fill", "markers fill stroke");
-test_attr("markers stroke", "markers stroke fill");
+test_attr("fill stroke", "fill");
+test_attr("fill markers", "fill markers");
+test_attr("stroke fill", "stroke");
+test_attr("stroke markers", "stroke markers");
+test_attr("markers fill", "markers");
+test_attr("markers stroke", "markers stroke");
debug("");
debug("Test invalid values of 'paint-order' (presentation attribute)");
-test_attr("foo", "fill stroke markers");
-test_attr("fill foo", "fill stroke markers");
-test_attr("stroke foo", "fill stroke markers");
-test_attr("markers foo", "fill stroke markers");
-test_attr("normal foo", "fill stroke markers");
-test_attr("fill markers stroke foo", "fill stroke markers");
+test_attr("foo", "normal");
+test_attr("fill foo", "normal");
+test_attr("stroke foo", "normal");
+test_attr("markers foo", "normal");
+test_attr("normal foo", "normal");
+test_attr("fill markers stroke foo", "normal");
var successfullyParsed = true;

Powered by Google App Engine
This is Rietveld 408576698