Fix feedback log collection.

chrome/browser/chromeos/system_logs/dbus_log_source.cc

Index: chrome/browser/chromeos/system_logs/dbus_log_source.cc
diff --git a/chrome/browser/chromeos/system_logs/dbus_log_source.cc b/chrome/browser/chromeos/system_logs/dbus_log_source.cc
index bed65eb730cbabad9783b75b4548b981d1fd4837..210710690eaa52c68046514029dc4f262a3029e4 100644
--- a/chrome/browser/chromeos/system_logs/dbus_log_source.cc
+++ b/chrome/browser/chromeos/system_logs/dbus_log_source.cc
@@ -10,10 +10,8 @@
 
 namespace chromeos {
 
-namespace {

[xiyuan, 2013/03/18 23:55:52]

Why removing this? Are the constants below needed elsewhere?

[rkc, 2013/03/19 00:09:02]

const char[] has internal linkage, so the anonymous namespace seemed
unnecessary.

[xiyuan, 2013/03/19 02:14:48]

True.

But removing the namespace makes it easier to introduce errors, e.g. one of the
included header file has a "extern const..." and could cause un-intended export
of the name.

Although coding style does not cover this, most of our code wraps the const in
anonymous namespace or using static and think we should keep it consistent.

[rkc, 2013/03/19 19:58:59]

I'll come over and discuss this with you, I feel a bit strongly about keeping
this approach.

 const char kDBusLogEntryShort[] = "dbus_summary";
 const char kDBusLogEntryLong[] = "dbus_details";
-}
 
 void DBusLogSource::Fetch(const SysLogsSourceCallback& callback) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));