Fix feedback log collection.

chrome/browser/chromeos/system_logs/dbus_log_source.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/system_logs/dbus_log_source.h"
 
 #include "chrome/browser/chromeos/system_logs/system_logs_fetcher.h"
 #include "content/public/browser/browser_thread.h"
 #include "dbus/dbus_statistics.h"
 
 namespace chromeos {
 
-namespace {

[xiyuan, 2013/03/18 23:55:52]

Why removing this? Are the constants below needed elsewhere?

[rkc, 2013/03/19 00:09:02]

const char[] has internal linkage, so the anonymous namespace seemed
unnecessary.

[xiyuan, 2013/03/19 02:14:48]

True.

But removing the namespace makes it easier to introduce errors, e.g. one of the
included header file has a "extern const..." and could cause un-intended export
of the name.

Although coding style does not cover this, most of our code wraps the const in
anonymous namespace or using static and think we should keep it consistent.

[rkc, 2013/03/19 19:58:59]

I'll come over and discuss this with you, I feel a bit strongly about keeping
this approach.

 const char kDBusLogEntryShort[] = "dbus_summary";
 const char kDBusLogEntryLong[] = "dbus_details";
-}
 
 void DBusLogSource::Fetch(const SysLogsSourceCallback& callback) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   DCHECK(!callback.is_null());
 
   SystemLogsResponse response;
   response[kDBusLogEntryShort] = dbus::statistics::GetAsString(
       dbus::statistics::SHOW_INTERFACE,
       dbus::statistics::FORMAT_ALL);
   response[kDBusLogEntryLong] = dbus::statistics::GetAsString(
       dbus::statistics::SHOW_METHOD,
       dbus::statistics::FORMAT_TOTALS);
   callback.Run(&response);
 }
 
 }  // namespace chromeos