Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Unified Diff: chrome/browser/ui/views/browser_action_view.cc

Issue 12529012: Context menu on views must show on mouse down for non-WIN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/menu/menu_controller.h » ('j') | ui/views/controls/menu/menu_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/browser_action_view.cc
diff --git a/chrome/browser/ui/views/browser_action_view.cc b/chrome/browser/ui/views/browser_action_view.cc
index 7a8a81ef112bd77d42c6ea474a75a621e6945147..f2102e2c0c25f3f880ea82bda4b4e0e78f4212e8 100644
--- a/chrome/browser/ui/views/browser_action_view.cc
+++ b/chrome/browser/ui/views/browser_action_view.cc
@@ -314,10 +314,6 @@ bool BrowserActionButton::OnMousePressed(const ui::MouseEvent& event) {
TextButton::OnMousePressed(event);
}
- // See comments in MenuButton::Activate() as to why this is needed.
sky 2013/04/04 20:36:04 Why are you removing this?
varunjain 2013/04/04 21:02:08 Now that we are showing context menu on mouse pres
- SetMouseHandler(NULL);
-
- ShowContextMenu(gfx::Point(), true);
return false;
}
« no previous file with comments | « no previous file | ui/views/controls/menu/menu_controller.h » ('j') | ui/views/controls/menu/menu_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698