Context menu on views must show on mouse down for non-WIN.

chrome/browser/ui/views/browser_action_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/browser_action_view.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/api/commands/command_service.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "chrome/browser/extensions/extension_action_manager.h"
@@ skipping 296 matching lines @@
   // to us.
   return false;
 }
 
 bool BrowserActionButton::OnMousePressed(const ui::MouseEvent& event) {
   if (!event.IsRightMouseButton()) {
     return IsPopup() ? MenuButton::OnMousePressed(event) :
                        TextButton::OnMousePressed(event);
   }
 
-  // See comments in MenuButton::Activate() as to why this is needed.

[sky, 2013/04/04 20:36:04]

Why are you removing this?

[varunjain, 2013/04/04 21:02:08]

Now that we are showing context menu on mouse press for all views, this is not
needed here since it would happen through normal views workflow in
View::ProcessedMousePressed. However, this should not be skipped on OS_WIN.
Adding it back with appropriate conditional.

-  SetMouseHandler(NULL);
-
-  ShowContextMenu(gfx::Point(), true);
   return false;
 }
 
 void BrowserActionButton::OnMouseReleased(const ui::MouseEvent& event) {
   if (IsPopup() || context_menu_) {
     // TODO(erikkay) this never actually gets called (probably because of the
     // loss of focus).
     MenuButton::OnMouseReleased(event);
   } else {
     TextButton::OnMouseReleased(event);
@@ skipping 71 matching lines @@
 
   extensions::Command browser_action_command;
   if (!only_if_active || !command_service->GetBrowserActionCommand(
           extension_->id(),
           extensions::CommandService::ACTIVE_ONLY,
           &browser_action_command,
           NULL)) {
     GetFocusManager()->UnregisterAccelerator(*keybinding_.get(), this);
   }
 }