Issue 12528011: Rebind frontend host when frontend renderer navigates to devtools url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12528011: Rebind frontend host when frontend renderer navigates to devtools url. (Closed)

Created:
7 years, 9 months ago by vsevik

Modified:
7 years, 9 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, darin-cc_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rebind frontend host when frontend renderer navigates to devtools url. BUG=180887 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186802

Patch Set 2 : Correct patch now #

Patch Set 3 : Protected agent host while rebinding. #

Total comments: 1

Patch Set 4 : Added new line #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -14 lines)			Patch
	M	chrome/browser/devtools/devtools_window.cc	View	1 2 3	1 chunk	+22 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/12528011/diff/4001/chrome/browser/devtools/devtools_window.cc File chrome/browser/devtools/devtools_window.cc (right): https://codereview.chromium.org/12528011/diff/4001/chrome/browser/devtools/devtools_window.cc#newcode502 chrome/browser/devtools/devtools_window.cc:502: if (inspected_web_contents_) Note that Vlad is removing the ...

7 years, 9 months ago (2013-03-07 18:30:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/12528011/7001

7 years, 9 months ago (2013-03-07 18:42:20 UTC) #3

Message was sent while issue was closed.

Change committed as 186802