Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 125280: Send port-closed notification when a frame with ports unloads.... (Closed)

Created:
11 years, 6 months ago by Matt Perry
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com, Erik does not do reviews
Visibility:
Public.

Description

Send port-closed notification when a frame with ports unloads. Also add onLoad and onUnload chrome Event to our bindings, so we can add listeners to these events without needing a DOM. These don't hook into the window "unload" event, so we no longer prevent Chrome's sudden termination of tabs on shutdown. BUG=12686 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18765

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 3

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -96 lines) Patch
M chrome/browser/automation/extension_port_container.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_service.h View 1 2 3 5 chunks +20 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 1 2 3 2 chunks +22 lines, -11 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.h View 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 2 3 2 chunks +11 lines, -6 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/event_bindings.h View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/event_bindings.cc View 1 2 3 4 chunks +25 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.cc View 1 2 3 4 5 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/renderer/extensions/renderer_extension_bindings.cc View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.h View 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 3 3 chunks +23 lines, -5 lines 0 comments Download
M chrome/renderer/render_widget.h View 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_resources.grd View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
MM chrome/renderer/resources/event_bindings.js View 1 2 3 5 chunks +26 lines, -5 lines 0 comments Download
MM chrome/renderer/resources/extension_process_bindings.js View 1 2 3 16 chunks +27 lines, -27 lines 0 comments Download
MM chrome/renderer/resources/greasemonkey_api.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/json_schema.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/renderer/resources/renderer_extension_bindings.js View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download
M webkit/glue/webframe.h View 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M webkit/glue/webframe_impl.h View 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/webframe_impl.cc View 2 3 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Matt Perry
11 years, 6 months ago (2009-06-17 22:44:02 UTC) #1
Aaron Boodman
http://codereview.chromium.org/125280/diff/3015/3020 File chrome/renderer/renderer_resources.grd (right): http://codereview.chromium.org/125280/diff/3015/3020#newcode3 Line 3: without changes to the corresponding grd file. 4 ...
11 years, 6 months ago (2009-06-18 04:49:45 UTC) #2
Matt Perry
I added a small change to fix the unit tests as well. http://codereview.chromium.org/125280/diff/3015/3028 File chrome/renderer/resources/event_bindings.js ...
11 years, 6 months ago (2009-06-18 19:48:58 UTC) #3
Aaron Boodman
11 years, 6 months ago (2009-06-18 21:27:32 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698