Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8721)

Unified Diff: chrome/renderer/extensions/extension_process_bindings.cc

Issue 125280: Send port-closed notification when a frame with ports unloads.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_process_bindings.cc
===================================================================
--- chrome/renderer/extensions/extension_process_bindings.cc (revision 18701)
+++ chrome/renderer/extensions/extension_process_bindings.cc (working copy)
@@ -14,12 +14,8 @@
#include "chrome/renderer/js_only_v8_extensions.h"
#include "chrome/renderer/render_view.h"
#include "grit/renderer_resources.h"
-#include "webkit/api/public/WebScriptSource.h"
#include "webkit/glue/webframe.h"
-using WebKit::WebScriptSource;
-using WebKit::WebString;
-
namespace {
const char kExtensionName[] = "chrome/ExtensionProcessBindings";
@@ -105,7 +101,9 @@
RenderView* renderview = GetRenderViewForCurrentContext();
DCHECK(renderview);
GURL url = renderview->webview()->GetMainFrame()->GetURL();
- DCHECK(url.scheme() == chrome::kExtensionScheme);
+ // Don't check the URL scheme in unit tests.
+ if (RenderThread::current())
+ DCHECK(url.scheme() == chrome::kExtensionScheme);
v8::Persistent<v8::Context> current_context =
v8::Persistent<v8::Context>::New(v8::Context::GetCurrent());
@@ -218,11 +216,6 @@
ExtensionImpl::SetFunctionNames(names);
}
-void ExtensionProcessBindings::RegisterExtensionContext(WebFrame* frame) {
- frame->ExecuteScript(WebScriptSource(WebString::fromUTF8(
- "chrome.self.register_();")));
-}
-
void ExtensionProcessBindings::HandleResponse(int request_id, bool success,
const std::string& response,
const std::string& error) {
Property changes on: chrome\renderer\extensions\extension_process_bindings.cc
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « chrome/renderer/extensions/extension_process_bindings.h ('k') | chrome/renderer/extensions/renderer_extension_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698