Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 125273006: Revert of Resubmit of imageWriterPrivate.destroyPartitions. (Closed)

Created:
6 years, 11 months ago by Drew Haven
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -380 lines) Patch
D chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/image_writer_private_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc View 1 chunk +1 line, -16 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_linux.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_manager.cc View 5 chunks +11 lines, -24 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc View 4 chunks +5 lines, -22 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/test_utils.h View 3 chunks +3 lines, -29 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/test_utils.cc View 1 chunk +11 lines, -104 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_file_operation_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/image_writer_private.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Drew Haven
Created Revert of Resubmit of imageWriterPrivate.destroyPartitions.
6 years, 11 months ago (2014-01-07 00:46:47 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 11 months ago (2014-01-07 00:48:42 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 11 months ago (2014-01-07 00:50:35 UTC) #3
Lei Zhang
lgtm stamp
6 years, 11 months ago (2014-01-07 00:52:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haven@chromium.org/125273006/1
6 years, 11 months ago (2014-01-07 00:54:33 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 00:56:38 UTC) #6
Message was sent while issue was closed.
Change committed as 243215

Powered by Google App Engine
This is Rietveld 408576698