chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc - Issue 125273006: Revert of Resubmit of imageWriterPrivate.destroyPartitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

Issue 125273006: Revert of Resubmit of imageWriterPrivate.destroyPartitions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/image_writer_private_api.h ('k') | chrome/browser/extensions/api/image_writer_private/operation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc b/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

index 3d7fd423688ddbdcc07fa89df1ada1072e419dfb..fffd1ac0fb200439a8bb903fc65b85a0498830ed 100644

--- a/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

+++ b/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

@@ -151,23 +151,8 @@

image_writer_api::DestroyPartitions::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

- image_writer::OperationManager::Get(GetProfile())->DestroyPartitions(

- extension_id(),

- params->storage_unit_id,

- base::Bind(

- &ImageWriterPrivateDestroyPartitionsFunction::OnDestroyComplete,

- this));

+ SendResponse(true);

return true;

-void ImageWriterPrivateDestroyPartitionsFunction::OnDestroyComplete(

- bool success,

- const std::string& error) {

- if (!success) {

- error_ = error;

- }

- SendResponse(success);

}

ImageWriterPrivateListRemovableStorageDevicesFunction::