Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 125253004: Simplify RTO interaction between the QUIC sent packet manager and the (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)
Modified:
6 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Simplify RTO interaction between the QUIC sent packet manager and the send algorithm. The manager no longer needs to abandon each packet individually. Merge internal change: 58755766 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -70 lines) Patch
M net/quic/congestion_control/fix_rate_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/fix_rate_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/inter_arrival_probe.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_probe.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/inter_arrival_sender.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/quic/congestion_control/pacing_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 1 chunk +10 lines, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 14 chunks +18 lines, -33 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 4 chunks +4 lines, -14 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 11 months ago (2014-01-06 18:31:47 UTC) #1
Ryan Hamilton
6 years, 11 months ago (2014-01-06 19:40:04 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698