Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 125253004: Simplify RTO interaction between the QUIC sent packet manager and the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.cc
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index 81da4798b2889fb7bbfc8b96e5a38b0f590fd22a..b81f594cd7d009a0e0ba78ba0e8775d63e94dea3 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -622,9 +622,6 @@ void QuicSentPacketManager::RetransmitOldestPacket() {
void QuicSentPacketManager::RetransmitAllPackets() {
// Abandon all retransmittable packets and packets older than the
// retransmission delay.
- QuicTime::Delta retransmission_delay = GetRetransmissionDelay();
- QuicTime max_send_time =
- clock_->ApproximateNow().Subtract(retransmission_delay);
DVLOG(1) << "OnRetransmissionTimeout() fired with "
<< unacked_packets_.size() << " unacked packets.";
@@ -637,18 +634,15 @@ void QuicSentPacketManager::RetransmitAllPackets() {
for (UnackedPacketMap::const_iterator it = unacked_packets_.begin();
it != unacked_packets_.end(); ++it) {
if (it->second.retransmittable_frames != NULL) {
- OnPacketAbandoned(it->first);
packets_retransmitted = true;
MarkForRetransmission(it->first, RTO_RETRANSMISSION);
- } else if (it->second.sent_time <= max_send_time) {
- OnPacketAbandoned(it->first);
}
}
- // Only inform the send algorithm of an RTO if data was retransmitted.
+ pending_packets_.clear();
+ send_algorithm_->OnRetransmissionTimeout(packets_retransmitted);
if (packets_retransmitted) {
++consecutive_rto_count_;
- send_algorithm_->OnRetransmissionTimeout();
}
}
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698