Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1252503006: Update ServiceWorkerVersionBrowserTest.FetchEvent_respondWithRejection (Closed)

Created:
5 years, 5 months ago by horo
Modified:
5 years, 4 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update ServiceWorkerVersionBrowserTest.FetchEvent_respondWithRejection https://codereview.chromium.org/1228233007/ adds another message. So this CL updates the expectation of the test. 1/3 chromium: https://codereview.chromium.org/1254523002/ 2/3 blink: https://codereview.chromium.org/1228233007/ 3/3 chromium: this cl. BUG=505784 Committed: https://crrev.com/e9ca9a85160ecd3c9e3ddbe74fe70e9babb9efae Cr-Commit-Position: refs/heads/master@{#340425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
horo
falken@ Could you please review this?
5 years, 5 months ago (2015-07-23 02:30:51 UTC) #2
falken
lgtm
5 years, 5 months ago (2015-07-23 07:36:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252503006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252503006/1
5 years, 4 months ago (2015-07-27 02:15:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-27 07:03:24 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 07:04:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9ca9a85160ecd3c9e3ddbe74fe70e9babb9efae
Cr-Commit-Position: refs/heads/master@{#340425}

Powered by Google App Engine
This is Rietveld 408576698