Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6573)

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 1252503006: Update ServiceWorkerVersionBrowserTest.FetchEvent_respondWithRejection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_browsertest.cc
diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc
index 72e70716227fbb313e17763b02414bcb23bb3b1c..d3bf449b5a415b2219254975819d6830046a1dbc 100644
--- a/content/browser/service_worker/service_worker_browsertest.cc
+++ b/content/browser/service_worker/service_worker_browsertest.cc
@@ -1082,7 +1082,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, FetchEvent_Response) {
}
IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
- DISABLED_FetchEvent_respondWithRejection) {
+ FetchEvent_respondWithRejection) {
ServiceWorkerFetchEventResult result;
ServiceWorkerResponse response;
scoped_ptr<storage::BlobDataHandle> blob_data_handle;
@@ -1094,11 +1094,14 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
version_->embedded_worker()->AddListener(&console_listener);
FetchOnRegisteredWorker(&result, &response, &blob_data_handle);
- const base::string16 expected =
- base::ASCIIToUTF16("Rejecting respondWith promise");
- console_listener.WaitForConsoleMessages(1);
+ const base::string16 expected1 = base::ASCIIToUTF16(
+ "resulted in a network error response: the promise was rejected.");
+ const base::string16 expected2 =
+ base::ASCIIToUTF16("Uncaught (in promise) Rejecting respondWith promise");
+ console_listener.WaitForConsoleMessages(2);
ASSERT_NE(base::string16::npos,
- console_listener.messages()[0].find(expected));
+ console_listener.messages()[0].find(expected1));
+ ASSERT_EQ(0u, console_listener.messages()[1].find(expected2));
version_->embedded_worker()->RemoveListener(&console_listener);
ASSERT_EQ(SERVICE_WORKER_FETCH_EVENT_RESULT_RESPONSE, result);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698