Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1252473002: Reduce SharedFunctionInfo size. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reduce SharedFunctionInfo size. The API function data and the debug info fields are never used at the same time, as API functions are not debuggable. We can share a field. R=jkummerow@chromium.org

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M src/factory.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects-inl.h View 2 chunks +2 lines, -1 line 1 comment Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 5 months ago (2015-07-22 12:17:34 UTC) #1
Yang
On 2015/07/22 12:17:34, Yang wrote: That saves a word per SFI, so for an new ...
5 years, 5 months ago (2015-07-22 12:18:51 UTC) #2
Jakob Kummerow
Yay! But I'd like to harden this a bit if possible. Field sharing is dangerous ...
5 years, 5 months ago (2015-07-22 12:24:03 UTC) #3
Michael Starzinger
Aehm, not so fast, are you aware of this CL: https://codereview.chromium.org/1230753004/
5 years, 5 months ago (2015-07-22 12:33:25 UTC) #5
Yang
5 years, 5 months ago (2015-07-22 12:38:26 UTC) #6
On 2015/07/22 12:33:25, Michael Starzinger wrote:
> Aehm, not so fast, are you aware of this CL:
> https://codereview.chromium.org/1230753004/

Thanks! I was not. I'll close this CL then.

Powered by Google App Engine
This is Rietveld 408576698