Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: src/objects-inl.h

Issue 1252473002: Reduce SharedFunctionInfo size. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index a4ca8c34e29eeec8737c7f0b3025952c319b54cd..1f73c74aebea09e4fadfbae211e95941039adf90 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -5476,7 +5476,7 @@ bool SharedFunctionInfo::is_simple_parameter_list() {
bool SharedFunctionInfo::HasDebugInfo() {
- bool has_debug_info = debug_info()->IsStruct();
+ bool has_debug_info = !IsApiFunction() && debug_info()->IsStruct();
Jakob Kummerow 2015/07/22 12:24:02 I can haz DCHECK(!IsApiFunction()) inside debug_in
DCHECK(!has_debug_info || HasDebugCode());
return has_debug_info;
}
@@ -5590,6 +5590,7 @@ void SharedFunctionInfo::TryReenableOptimization() {
bool SharedFunctionInfo::IsSubjectToDebugging() {
+ if (IsApiFunction()) return false;
Object* script_obj = script();
if (script_obj->IsUndefined()) return false;
Script* script = Script::cast(script_obj);
« no previous file with comments | « src/objects.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698