Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1252463002: [turbofan] Preserve cached code across GCs. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_opt-code-map-8
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Preserve cached code across GCs. This preserves the context-independent entry in an optimized code map across GCs when the code is considered young (i.e. less than 3 ages). Note that any context-dependent entry for the same code will still be flushed immediately when the respective context dies, hence context lifetime is not increased. R=hpayer@chromium.org Committed: https://crrev.com/2c07b0d045829da2e61e7c94bdcba89581e4866b Cr-Commit-Position: refs/heads/master@{#29790}

Patch Set 1 #

Patch Set 2 : Flip default to "off", in our moment of triumph. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M src/flag-definitions.h View 1 1 chunk +1 line, -0 lines 1 comment Download
M src/heap/objects-visiting.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +19 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 5 months ago (2015-07-22 11:57:28 UTC) #1
Michael Starzinger
https://codereview.chromium.org/1252463002/diff/20001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1252463002/diff/20001/src/flag-definitions.h#newcode434 src/flag-definitions.h:434: DEFINE_BOOL(turbo_preserve_shared_code, false, "keep context-independent code") Note that this is ...
5 years, 5 months ago (2015-07-22 11:59:22 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 5 months ago (2015-07-22 12:46:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252463002/20001
5 years, 5 months ago (2015-07-22 14:02:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 14:04:09 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 14:04:14 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c07b0d045829da2e61e7c94bdcba89581e4866b
Cr-Commit-Position: refs/heads/master@{#29790}

Powered by Google App Engine
This is Rietveld 408576698