Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1249543005: Allow for optimized code map to have zero entries. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow for optimized code map to have zero entries. This allows the optimized code map to contain no context-dependent entries, but still hold one context-independent entry. This is a precursor to extending the lifetime of the context-independent entry. R=mvstanton@chromium.org Committed: https://crrev.com/1c857357102547580d7b8444e4dc81c2113da34d Cr-Commit-Position: refs/heads/master@{#29788}

Patch Set 1 #

Patch Set 2 : Added test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -61 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +47 lines, -59 lines 0 comments Download
M src/objects.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 1 chunk +58 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (2 generated)
Michael Starzinger
5 years, 5 months ago (2015-07-21 16:36:34 UTC) #1
mvstanton
Totally awesome! LGTM. Do you have a test that creates turbofan context-independent code that gets ...
5 years, 5 months ago (2015-07-22 07:28:04 UTC) #2
Michael Starzinger
On 2015/07/22 07:28:04, mvstanton wrote: > Totally awesome! > LGTM. > Do you have a ...
5 years, 5 months ago (2015-07-22 08:01:02 UTC) #3
Michael Starzinger
Added test case. PTAL.
5 years, 5 months ago (2015-07-22 08:33:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1249543005/20001
5 years, 5 months ago (2015-07-22 11:44:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 11:46:09 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 11:47:04 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c857357102547580d7b8444e4dc81c2113da34d
Cr-Commit-Position: refs/heads/master@{#29788}

Powered by Google App Engine
This is Rietveld 408576698