Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1252443003: Revert of Shows error messages in the inspector when .respondWith() is called with wrong responses. (Closed)

Created:
5 years, 5 months ago by yhirano
Modified:
5 years, 5 months ago
Reviewers:
falken, Mike West, horo
CC:
blink-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Shows error messages in the inspector when .respondWith() is called with wrong responses. (patchset #4 id:100001 of https://codereview.chromium.org/1228233007/) Reason for revert: Causes content_browsertests failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/45600 Original issue's description: > Shows error messages in the inspector when .respondWith() is called with wrong responses. > > To let the developer know about the reason of the failure. > > BUG=505784 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199287 TBR=mkwst@chromium.org,falken@chromium.org,horo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=505784 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -47 lines) Patch
M Source/modules/serviceworkers/RespondWithObserver.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 4 chunks +3 lines, -43 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
yhirano
Created Revert of Shows error messages in the inspector when .respondWith() is called with wrong ...
5 years, 5 months ago (2015-07-22 09:47:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252443003/1
5 years, 5 months ago (2015-07-22 09:48:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199298
5 years, 5 months ago (2015-07-22 09:50:10 UTC) #3
horo
5 years, 5 months ago (2015-07-24 01:53:47 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1250363002/ by horo@chromium.org.

The reason for reverting is: Temporarily disabled the falling test
(ServiceWorkerVersionBrowserTest.FetchEvent_respondWithRejection)
https://crrev.com/1254523002

https://codereview.chromium.org/1252503006/ will update the test expectation.
.

Powered by Google App Engine
This is Rietveld 408576698