Support Telemetry tests on Android Mandoline.

Support Telemetry tests on Android Mandoline.

This CL adds backend and finder classes for Android Mandoline.

BUG=504442
Committed: https://crrev.com/ac061e0d8e5c845c78bea4fa6ac5e9bf63d516e0
Cr-Commit-Position: refs/heads/master@{#341606}

[yzshen1, 2015-07-27 23:26:15]

Patchset #1 (id:1) has been deleted

[yzshen1, 2015-07-27 23:29:44]

yzshen@chromium.org changed reviewers:
+ nednguyen@chromium.org, nednguyen@google.com

[yzshen1, 2015-07-27 23:29:45]

Hi, Ned.

Would you please take a look? Thanks!

https://codereview.chromium.org/1252253003/diff/20001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
(right):

https://codereview.chromium.org/1252253003/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:22:
pass
This try-except is to make pylint happy. Please let me know if there is a better
way to do it. Thanks!

[nednguyen, 2015-07-28 01:42:02]

https://codereview.chromium.org/1252253003/diff/20001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
(right):

https://codereview.chromium.org/1252253003/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:4:

Can you resubmit the patch with a lower --similarity theshold so I can see the
diff between this and android_browser_backend?

[yzshen1, 2015-07-28 05:15:32]

On 2015/07/28 01:42:02, nednguyen wrote:
>
https://codereview.chromium.org/1252253003/diff/20001/tools/telemetry/telemet...
> File
>
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
> (right):
> 
>
https://codereview.chromium.org/1252253003/diff/20001/tools/telemetry/telemet...
>
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:4:
> 
> Can you resubmit the patch with a lower --similarity theshold so I can see the
> diff between this and android_browser_backend?

Done. I used 20% similarity.

[nednguyen, 2015-07-28 14:57:25]

https://codereview.chromium.org/1252253003/diff/80001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
(right):

https://codereview.chromium.org/1252253003/diff/80001/tools/telemetry/telemet...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:17:
util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'mojo', 'tools')
Hmh, we don't want to add any extra dependencies to telemetry that are not in
src/third_party/ so we can move it to https://github.com/catapult-project

I am not sure how to deal with this. Can your mojo tools live in
chromium/src/third_party or copied over to telemetry/..?

[yzshen1, 2015-07-28 15:55:11]

On 2015/07/28 14:57:25, nednguyen wrote:
>
https://codereview.chromium.org/1252253003/diff/80001/tools/telemetry/telemet...
> File
>
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
> (right):
> 
>
https://codereview.chromium.org/1252253003/diff/80001/tools/telemetry/telemet...
>
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:17:
> util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'mojo', 'tools')
> Hmh, we don't want to add any extra dependencies to telemetry that are not in
> src/third_party/ so we can move it to https://github.com/catapult-project
> 
> I am not sure how to deal with this. Can your mojo tools live in
> chromium/src/third_party or copied over to telemetry/..?
It will seems a little weird to move mojo/tools there. :/
It seems okay for mandoline finder and backend to depend on mandoline-related
scripts. This part is not platform/browser-neutral code. When we move telemetry
to another repo, this part could stay in the chromium repo. (I feel the same way
for other chrome finders and backends.)

What do you think? Thanks!

[nednguyen, 2015-07-29 04:30:03]

On 2015/07/28 15:55:11, yzshen1 wrote:
> On 2015/07/28 14:57:25, nednguyen wrote:
> >
>
https://codereview.chromium.org/1252253003/diff/80001/tools/telemetry/telemet...
> > File
> >
>
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
> > (right):
> > 
> >
>
https://codereview.chromium.org/1252253003/diff/80001/tools/telemetry/telemet...
> >
>
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:17:
> > util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'mojo', 'tools')
> > Hmh, we don't want to add any extra dependencies to telemetry that are not
in
> > src/third_party/ so we can move it to https://github.com/catapult-project
> > 
> > I am not sure how to deal with this. Can your mojo tools live in
> > chromium/src/third_party or copied over to telemetry/..?
> It will seems a little weird to move mojo/tools there. :/
> It seems okay for mandoline finder and backend to depend on mandoline-related
> scripts. This part is not platform/browser-neutral code. When we move
telemetry
> to another repo, this part could stay in the chromium repo. (I feel the same
way
> for other chrome finders and backends.)

Hmh, this is another grant design question that need to be fleshed out too. We
have been hesitant to support people writing their own core app logic,
especially the chrome finders & backends part. There are too many moving pieces
in telemetry for us to reconsider this big change of direction, do you want to
postpone this work until we move telemetry to catapult?

> 
> What do you think? Thanks!

[nednguyen, 2015-07-29 16:46:31]

nednguyen@google.com changed reviewers:
+ aiolos@chromium.org

[nednguyen, 2015-07-29 16:46:32]

+Kari

https://codereview.chromium.org/1252253003/diff/80001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
(right):

https://codereview.chromium.org/1252253003/diff/80001/tools/telemetry/telemet...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:17:
util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'mojo', 'tools')
if global_config.HasMojoToolPath():
   util.AddDirToPythonPath(global_config.GetMojoToolPath())

+Kari

[aiolos (Not reviewing), 2015-07-29 22:56:20]

https://codereview.chromium.org/1252253003/diff/80001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
(right):

https://codereview.chromium.org/1252253003/diff/80001/tools/telemetry/telemet...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:17:
util.AddDirToPythonPath(util.GetChromiumSrcDir(), 'mojo', 'tools')
On 2015/07/29 16:46:31, nednguyen wrote:
> if global_config.HasMojoToolPath():
>    util.AddDirToPythonPath(global_config.GetMojoToolPath())
> 
> +Kari

We discussed offline. Solution: add the mojo files to telemetry/third_party
until the dependency manager is finished, and then switch over to using that.

[aiolos (Not reviewing), 2015-07-29 23:14:14]

https://codereview.chromium.org/1252253003/diff/80001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/internal/backends/mandoline/mandoline_browser_backend.py
(right):

https://codereview.chromium.org/1252253003/diff/80001/tools/telemetry/telemet...
tools/telemetry/telemetry/internal/backends/mandoline/mandoline_browser_backend.py:41:
args = [arg for arg in self.browser_options.extra_browser_args
Is the intention to remove them for all platforms, or just Android?

If the former, please put a check in to only filter the args if you're on
android (or even better, filter them in the android_mandoline_backend when you
initialize this class instead.)

If the latter, please update the comment to reflect that this is happening on
all platforms.

[yzshen1, 2015-07-29 23:55:07]

Thanks Ned and Kari!

Please take another look.

https://codereview.chromium.org/1252253003/diff/80001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/internal/backends/mandoline/mandoline_browser_backend.py
(right):

https://codereview.chromium.org/1252253003/diff/80001/tools/telemetry/telemet...
tools/telemetry/telemetry/internal/backends/mandoline/mandoline_browser_backend.py:41:
args = [arg for arg in self.browser_options.extra_browser_args
On 2015/07/29 23:14:14, aiolos wrote:
> Is the intention to remove them for all platforms, or just Android?
> 
> If the former, please put a check in to only filter the args if you're on
> android (or even better, filter them in the android_mandoline_backend when you
> initialize this class instead.)
> 
> If the latter, please update the comment to reflect that this is happening on
> all platforms.

Thanks. I moved this part into android_mandoline_backend

[nednguyen, 2015-07-30 18:20:04]

nednguyen@google.com changed reviewers:
+ jbudorick@chromium.org
- nednguyen@chromium.org

[nednguyen, 2015-07-30 18:20:06]

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
File
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
(right):

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:21:
from mopy.android import AndroidShell
We only import for modules & packages in telemetry

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:76:
if self.browser_options.startup_url != "about:blank":
Can you raise UnimplementedError here if it's not supported. I usually want
non-supported options to be crashy rather than silent.

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:96:
self.device.RunShellCommand('input keyevent 82')
self.device.SendKeyEvent(pylib.constants.keyevent.XYZ)

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:104:
sys.exit(1)
Why catch exception and then exit?

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:108:
self.Close()
if this is want you want, do:

try:

  ...
finally:
  self.Close()

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:157:
# doesn't expose necessary API.
+jbudorick: do we have way to undo the port forwarding?

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:191:
dynamic_port_begin = 32768
Where are these magic numbers from?

[jbudorick, 2015-07-30 18:30:30]

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
File
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
(right):

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:157:
# doesn't expose necessary API.
On 2015/07/30 at 18:20:05, nednguyen wrote:
> +jbudorick: do we have way to undo the port forwarding?

presuming you mean an AdbWrapper version of

  adb forward --remove

then no, though adding one should be pretty simple.

[yzshen1, 2015-07-30 20:22:58]

Thanks!

Please take another look.

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
File
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
(right):

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:21:
from mopy.android import AndroidShell
On 2015/07/30 18:20:05, nednguyen wrote:
> We only import for modules & packages in telemetry

This is now in telemetry/third_party/mojo/tools/mopy. I thought it should be
okay?

Maybe I haven't understood your comment. Would you please elaborate?

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:76:
if self.browser_options.startup_url != "about:blank":
On 2015/07/30 18:20:05, nednguyen wrote:
> Can you raise UnimplementedError here if it's not supported. I usually want
> non-supported options to be crashy rather than silent.

We do want to proceed even if we encounter about:blank. For example, currently
we run blink_perf.dom by ignoring the startup URL about:blank.

I added a warning for this.

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:96:
self.device.RunShellCommand('input keyevent 82')
On 2015/07/30 18:20:05, nednguyen wrote:
> self.device.SendKeyEvent(pylib.constants.keyevent.XYZ)

Done.

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:104:
sys.exit(1)
On 2015/07/30 18:20:05, nednguyen wrote:
> Why catch exception and then exit?

I followed the behavior of android_browser_backend.py.
I think it would be nice if the two behave the same. WDYT? Thanks!

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:108:
self.Close()
On 2015/07/30 18:20:05, nednguyen wrote:
> if this is want you want, do:
> 
> try:
> 
>   ...
> finally:
>   self.Close()

Please see my previous comment. Thanks!

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:157:
# doesn't expose necessary API.
On 2015/07/30 18:30:30, jbudorick wrote:
> On 2015/07/30 at 18:20:05, nednguyen wrote:
> > +jbudorick: do we have way to undo the port forwarding?
> 
> presuming you mean an AdbWrapper version of
> 
>   adb forward --remove
> 
> then no, though adding one should be pretty simple.

If you think it is okay, I won't worry about removing port forwarding in this CL
then.

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:191:
dynamic_port_begin = 32768
On 2015/07/30 18:20:05, nednguyen wrote:
> Where are these magic numbers from?

That is the range of ephemeral ports that we use on Android, I think.
I added a comment for it.

[nednguyen, 2015-07-30 20:26:30]

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
File
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
(right):

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:21:
from mopy.android import AndroidShell
On 2015/07/30 20:22:57, yzshen1 wrote:
> On 2015/07/30 18:20:05, nednguyen wrote:
> > We only import for modules & packages in telemetry
> 
> This is now in telemetry/third_party/mojo/tools/mopy. I thought it should be
> okay?
> 
> Maybe I haven't understood your comment. Would you please elaborate?

I mean you should do:
from mopy import android
from mopy import config
...
do stuffs with android.AndroidShell
do stuffs with config.Config

It's just a a styling thing

[yzshen1, 2015-07-30 20:33:31]

On 2015/07/30 20:26:30, nednguyen wrote:
>
https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
> File
>
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
> (right):
> 
>
https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
>
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:21:
> from mopy.android import AndroidShell
> On 2015/07/30 20:22:57, yzshen1 wrote:
> > On 2015/07/30 18:20:05, nednguyen wrote:
> > > We only import for modules & packages in telemetry
> > 
> > This is now in telemetry/third_party/mojo/tools/mopy. I thought it should be
> > okay?
> > 
> > Maybe I haven't understood your comment. Would you please elaborate?
> 
> I mean you should do:
> from mopy import android
> from mopy import config
> ...
> do stuffs with android.AndroidShell
> do stuffs with config.Config
> 
> It's just a a styling thing

Done. Thanks!

[yzshen1, 2015-07-31 18:27:43]

On 2015/07/30 20:33:31, yzshen1 wrote:
> On 2015/07/30 20:26:30, nednguyen wrote:
> >
>
https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
> > File
> >
>
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
> > (right):
> > 
> >
>
https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
> >
>
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:21:
> > from mopy.android import AndroidShell
> > On 2015/07/30 20:22:57, yzshen1 wrote:
> > > On 2015/07/30 18:20:05, nednguyen wrote:
> > > > We only import for modules & packages in telemetry
> > > 
> > > This is now in telemetry/third_party/mojo/tools/mopy. I thought it should
be
> > > okay?
> > > 
> > > Maybe I haven't understood your comment. Would you please elaborate?
> > 
> > I mean you should do:
> > from mopy import android
> > from mopy import config
> > ...
> > do stuffs with android.AndroidShell
> > do stuffs with config.Config
> > 
> > It's just a a styling thing
> 
> Done. Thanks!

Friendly ping, Ned and Kari. Thanks!

[nednguyen, 2015-07-31 18:36:23]

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
File
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
(right):

https://codereview.chromium.org/1252253003/diff/100001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:104:
sys.exit(1)
On 2015/07/30 20:22:57, yzshen1 wrote:
> On 2015/07/30 18:20:05, nednguyen wrote:
> > Why catch exception and then exit?
> 
> I followed the behavior of android_browser_backend.py.
> I think it would be nice if the two behave the same. WDYT? Thanks!

*Sigh, bad code does leave legacy. But I agree that making sure the two behaving
the same is better. Can you make a next patch to clean the code up?

https://codereview.chromium.org/1252253003/diff/140001/tools/telemetry/teleme...
File
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
(right):

https://codereview.chromium.org/1252253003/diff/140001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:97:
shell.InitShell(origin=None)
Hmh, this seems wrong. Shouldn't you specify that this shell is associated with
the device whose id the current platform backend is pointing to?

[yzshen1, 2015-07-31 19:29:26]

Thanks Ned! PTAL.

https://codereview.chromium.org/1252253003/diff/140001/tools/telemetry/teleme...
File
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py
(right):

https://codereview.chromium.org/1252253003/diff/140001/tools/telemetry/teleme...
tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py:97:
shell.InitShell(origin=None)
On 2015/07/31 18:36:23, nednguyen wrote:
> Hmh, this seems wrong. Shouldn't you specify that this shell is associated
with
> the device whose id the current platform backend is pointing to?

Done.

[nednguyen, 2015-07-31 19:32:17]

lgtm

[yzshen1, 2015-07-31 20:01:33]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2015-07-31 20:01:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252253003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252253003/160001

[commit-bot: I haz the power, 2015-07-31 22:15:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-31 22:15:35]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[yzshen1, 2015-08-03 16:44:39]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2015-08-03 16:44:39]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1252253003/#ps180001
(title: "move mojo scripts from third_party/ to
telemetry/internal/backends/mandoline/ to avoid introducing …")

[commit-bot: I haz the power, 2015-08-03 16:45:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252253003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252253003/180001

[commit-bot: I haz the power, 2015-08-03 16:48:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-03 16:48:33]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yzshen1, 2015-08-03 16:56:29]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2015-08-03 16:56:29]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1252253003/#ps200001
(title: " ")

[commit-bot: I haz the power, 2015-08-03 16:56:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252253003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252253003/200001

[commit-bot: I haz the power, 2015-08-03 17:40:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-03 17:40:51]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yzshen1, 2015-08-03 17:42:46]

On 2015/08/03 16:56:55, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1252253003/200001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1252253003/200001

Hi, Ned and Kari.

I met the following failure:
====================================================
[872/875]
telemetry.telemetry_dependencies_unittest.TelemetryDependenciesTest.testNoNewTelemetryDependencies
failed unexpectedly 20.1567s:
  Traceback (most recent call last):
    File
"/b/build/slave/mac/build/src/tools/telemetry/telemetry/telemetry_dependencies_unittest.py",
line 57, in testNoNewTelemetryDependencies
      'Extra dependencies:\n%s' % '\n'.join(extra_dep_paths))
  AssertionError: Your patch adds new dependencies to telemetry. Please contact
aiolos@,dtu@, or nednguyen@ on how to proceed with this change. Extra
dependencies:
  /b/build/slave/mac/build/src/build/android/lighttpd_server.py
====================================================

Would you please let me know what to do with this? Thank you!

[yzshen1, 2015-08-03 17:59:05]

On 2015/08/03 17:42:46, yzshen1 wrote:
> On 2015/08/03 16:56:55, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/1252253003/200001
> > View timeline at
> >  https://chromium-cq-status.appspot.com/patch-timeline/1252253003/200001
> 
> Hi, Ned and Kari.
> 
> I met the following failure:
> ====================================================
> [872/875]
>
telemetry.telemetry_dependencies_unittest.TelemetryDependenciesTest.testNoNewTelemetryDependencies
> failed unexpectedly 20.1567s:
>   Traceback (most recent call last):
>     File
>
"/b/build/slave/mac/build/src/tools/telemetry/telemetry/telemetry_dependencies_unittest.py",
> line 57, in testNoNewTelemetryDependencies
>       'Extra dependencies:\n%s' % '\n'.join(extra_dep_paths))
>   AssertionError: Your patch adds new dependencies to telemetry. Please
contact
> aiolos@,dtu@, or nednguyen@ on how to proceed with this change. Extra
> dependencies:
>   /b/build/slave/mac/build/src/build/android/lighttpd_server.py
> ====================================================
> 
> Would you please let me know what to do with this? Thank you!

Please ignore this question.

I noticed that the latest android.py has removed the http-server-related code.
I will test and see whether it has removed the dependency.

[yzshen1, 2015-08-03 18:04:51]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2015-08-03 18:04:52]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1252253003/#ps220001
(title: " ")

[commit-bot: I haz the power, 2015-08-03 18:06:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252253003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252253003/220001

[commit-bot: I haz the power, 2015-08-03 18:10:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-03 18:11:00]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yzshen1, 2015-08-03 18:15:27]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2015-08-03 18:15:27]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1252253003/#ps240001
(title: " ")

[commit-bot: I haz the power, 2015-08-03 18:17:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252253003/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252253003/240001

[commit-bot: I haz the power, 2015-08-03 19:32:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-03 19:32:29]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yzshen1, 2015-08-03 20:18:53]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2015-08-03 20:19:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1252253003/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1252253003/240001

[commit-bot: I haz the power, 2015-08-03 20:53:54]

Committed patchset #12 (id:240001)

[commit-bot: I haz the power, 2015-08-03 20:54:36]

Patchset 12 (id:??) landed as
https://crrev.com/ac061e0d8e5c845c78bea4fa6ac5e9bf63d516e0
Cr-Commit-Position: refs/heads/master@{#341606}