tools/telemetry/telemetry/internal/backends/mandoline/desktop_mandoline_backend.py - Issue 1252253003: Support Telemetry tests on Android Mandoline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/backends/mandoline/desktop_mandoline_backend.py

Issue 1252253003: Support Telemetry tests on Android Mandoline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@7_android_tele

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/internal/backends/mandoline/config.py ('k') | tools/telemetry/telemetry/internal/backends/mandoline/paths.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/backends/mandoline/desktop_mandoline_backend.py

diff --git a/tools/telemetry/telemetry/internal/backends/mandoline/desktop_mandoline_backend.py b/tools/telemetry/telemetry/internal/backends/mandoline/desktop_mandoline_backend.py

index 5cafe1923020a466b8f7cf73d8e958f0f2dda8c8..216b4d73bcb9436ba55a463126eebb45edcc0733 100644

--- a/tools/telemetry/telemetry/internal/backends/mandoline/desktop_mandoline_backend.py

+++ b/tools/telemetry/telemetry/internal/backends/mandoline/desktop_mandoline_backend.py

@@ -63,6 +63,8 @@ class DesktopMandolineBackend(

# TODO(yzshen): For now "about:blank" is not supported yet.

if self.browser_options.startup_url != "about:blank":

args.append(self.browser_options.startup_url)

+ else:

+ logging.warning('Ignoring startup URL about:blank.')

env = os.environ.copy()

logging.debug('Starting Mandoline %s', args)