Closes stdin after starting a new process for a test.

Closes stdin after starting a new process for a test.

It is a mistake if a test tries to block to wait for
input on stdin. If we close stdin in the test script
after the test process starts, reading from stdin
will indicate that a test can fail immediately
rather than timing out.
Committed: https://code.google.com/p/dart/source/detail?r=20386

[Mads Ager (google), 2013-03-22 06:27:57]

This seems like a good idea. However, it seems that the only reason you can
currently do this is that the stdin stream actually implements more than the
Stream interface. It is probably exposing a full socket interface as well, it
shouldn't. I don't think there is a close method on the Stream interface. This
changelist illustrates that it makes sense to be able to signal that you do not
want a stream to be used.

If Søren agrees, I'm fine with landing this change. We can then consider how to
actually support this when we restrict the stdin interface to the actual Stream
interface. Either in dart:io or directly in dart:async.

[Søren Gjesse, 2013-03-22 07:06:26]

lgtm

Regarding Mads' comment then stdin of a new process is an IOSink and it do have
close method. I think the object exposed only has IOSink methods.

The running process stdin is declared as a Stream<List<int>>, but there we
probably do expose a Socket object.

[Mads Ager (google), 2013-03-22 07:18:55]

Thanks, yes I was confused about the direction here. I wonder if it still makes
sense to close a stream for subscriptions? But that is unrelated to this change.

[zra, 2013-03-22 16:45:50]

Committed patchset #1 manually as r20386 (presubmit successful).

[zra, 2013-03-22 16:46:30]

On 2013/03/22 16:45:50, zra wrote:
> Committed patchset #1 manually as r20386 (presubmit successful).

Thanks!