Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 12521010: Turning on warning as error on Linux (Closed)

Created:
7 years, 9 months ago by sugoi1
Modified:
7 years, 9 months ago
Reviewers:
bsalomon, sugoi, caryclark, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Turning on warning as error on Linux Fixed the few remaining warnings and turned on warning as error on Linux. Explicitly turned off warning as error in libjpeg, cityhash and json. Committed: https://code.google.com/p/skia/source/detail?r=8067

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -10 lines) Patch
M gyp/common_conditions.gypi View 1 1 chunk +1 line, -3 lines 0 comments Download
M gyp/jsoncpp.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M gyp/libjpeg.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M gyp/utils.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/animator/SkDrawExtraPathEffect.cpp View 1 3 chunks +14 lines, -6 lines 0 comments Download
M src/pdf/SkPDFCatalog.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sugoi
This current patch seems to pass the trybots, so it should be good to go.
7 years, 9 months ago (2013-03-08 17:50:39 UTC) #1
bsalomon
On 2013/03/08 17:50:39, sugoi wrote: > This current patch seems to pass the trybots, so ...
7 years, 9 months ago (2013-03-08 18:21:41 UTC) #2
reed1
adding cary, who understands the animator code. Your change seems right, in that w/o it ...
7 years, 9 months ago (2013-03-11 15:59:14 UTC) #3
caryclark
(animator change) lgtm
7 years, 9 months ago (2013-03-11 17:00:42 UTC) #4
sugoi1
7 years, 9 months ago (2013-03-11 18:45:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r8067 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698