Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gyp/common_conditions.gypi

Issue 12521010: Turning on warning as error on Linux (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gyp/jsoncpp.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
===================================================================
--- gyp/common_conditions.gypi (revision 8038)
+++ gyp/common_conditions.gypi (working copy)
@@ -140,9 +140,7 @@
},
},
'cflags': [
- # TODO(tony): Enable -Werror once all the strict-aliasing problems
- # are fixed.
- #'-Werror',
+ '-Werror',
'-Wall',
'-Wextra',
# suppressions below here were added for clang
« no previous file with comments | « no previous file | gyp/jsoncpp.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698