Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 1252093002: [turbofan] Remove bloated GraphBuilder base class. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
Reviewers:
titzer, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove bloated GraphBuilder base class. Using the GraphBuilder base class forces each node creation to go through a virtual function dispatch just for the sake of saving the duplication of the NewNode helper methods. In total that added up to saving minus (sic!) six lines of code. R=titzer@chromium.org Committed: https://crrev.com/0788c98d3b3854cb35d3c1534ff5382824f859cf Cr-Commit-Position: refs/heads/master@{#29799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -102 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D src/compiler/graph-builder.h View 1 chunk +0 lines, -82 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 5 chunks +46 lines, -5 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 7 chunks +46 lines, -10 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 5 months ago (2015-07-23 07:32:45 UTC) #1
Jarin
lgtm
5 years, 5 months ago (2015-07-23 07:37:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1252093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1252093002/1
5 years, 5 months ago (2015-07-23 07:56:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 08:25:34 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 08:25:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0788c98d3b3854cb35d3c1534ff5382824f859cf
Cr-Commit-Position: refs/heads/master@{#29799}

Powered by Google App Engine
This is Rietveld 408576698