Issue 1248263003: [turbofan] Add some documenting comments to RawMachineAssembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1248263003: [turbofan] Add some documenting comments to RawMachineAssembler. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger

Modified:
5 years, 5 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-graph-builder-base

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Add some documenting comments to RawMachineAssembler. R=jarin@chromium.org Committed: https://crrev.com/af6e874e7891b308086cc044efa7f1750f9338fd Cr-Commit-Position: refs/heads/master@{#29800}

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -20 lines)			Patch
	M	src/compiler/raw-machine-assembler.h	View		8 chunks	+33 lines, -18 lines	0 comments	Download
	M	src/compiler/raw-machine-assembler.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Depends on Patchset:

Issue 1252093002 Patch 1

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1248263003/1

5 years, 5 months ago (2015-07-23 09:00:18 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-23 09:17:03 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/af6e874e7891b308086cc044efa7f1750f9338fd
Cr-Commit-Position: refs/heads/master@{#29800}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages