Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2263)

Unified Diff: chrome/browser/permissions/permission_context_base.cc

Issue 1252073002: Move pref names and default value into WebsiteSettingsInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@website-settings-registry-simple
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_base.cc
diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc
index 7d2d173735b3b958bccf80622f54fe8cf523a56e..8933d1f5b65f83bc00a29b324e3667eb5ff9dd33 100644
--- a/chrome/browser/permissions/permission_context_base.cc
+++ b/chrome/browser/permissions/permission_context_base.cc
@@ -13,8 +13,8 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
#include "chrome/common/pref_names.h"
-#include "components/content_settings/core/browser/content_settings_utils.h"
#include "components/content_settings/core/browser/host_content_settings_map.h"
+#include "components/content_settings/core/browser/website_settings_registry.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/origin_util.h"
@@ -99,12 +99,15 @@ void PermissionContextBase::DecidePermission(
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
if (!requesting_origin.is_valid() || !embedding_origin.is_valid()) {
- DVLOG(1)
- << "Attempt to use " << content_settings::GetTypeName(permission_type_)
- << " from an invalid URL: " << requesting_origin
- << "," << embedding_origin
- << " (" << content_settings::GetTypeName(permission_type_)
- << " is not supported in popups)";
+ std::string type_name =
+ content_settings::WebsiteSettingsRegistry::GetInstance()
+ ->Get(permission_type_)
+ ->name();
+
+ DVLOG(1) << "Attempt to use " << type_name
+ << " from an invalid URL: " << requesting_origin << ","
+ << embedding_origin << " (" << type_name
+ << " is not supported in popups)";
NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
false /* persist */, CONTENT_SETTING_BLOCK);
return;

Powered by Google App Engine
This is Rietveld 408576698