Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: chrome/browser/permissions/permission_context_base.cc

Issue 1252073002: Move pref names and default value into WebsiteSettingsInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@website-settings-registry-simple
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_context_base.h" 5 #include "chrome/browser/permissions/permission_context_base.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "chrome/browser/permissions/permission_bubble_request_impl.h" 9 #include "chrome/browser/permissions/permission_bubble_request_impl.h"
10 #include "chrome/browser/permissions/permission_context_uma_util.h" 10 #include "chrome/browser/permissions/permission_context_uma_util.h"
11 #include "chrome/browser/permissions/permission_queue_controller.h" 11 #include "chrome/browser/permissions/permission_queue_controller.h"
12 #include "chrome/browser/permissions/permission_request_id.h" 12 #include "chrome/browser/permissions/permission_request_id.h"
13 #include "chrome/browser/profiles/profile.h" 13 #include "chrome/browser/profiles/profile.h"
14 #include "chrome/browser/ui/website_settings/permission_bubble_manager.h" 14 #include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
15 #include "chrome/common/pref_names.h" 15 #include "chrome/common/pref_names.h"
16 #include "components/content_settings/core/browser/content_settings_utils.h"
17 #include "components/content_settings/core/browser/host_content_settings_map.h" 16 #include "components/content_settings/core/browser/host_content_settings_map.h"
17 #include "components/content_settings/core/browser/website_settings_registry.h"
18 #include "content/public/browser/browser_thread.h" 18 #include "content/public/browser/browser_thread.h"
19 #include "content/public/browser/web_contents.h" 19 #include "content/public/browser/web_contents.h"
20 #include "content/public/common/origin_util.h" 20 #include "content/public/common/origin_util.h"
21 21
22 PermissionContextBase::PermissionContextBase( 22 PermissionContextBase::PermissionContextBase(
23 Profile* profile, 23 Profile* profile,
24 const ContentSettingsType permission_type) 24 const ContentSettingsType permission_type)
25 : profile_(profile), 25 : profile_(profile),
26 permission_type_(permission_type), 26 permission_type_(permission_type),
27 weak_factory_(this) { 27 weak_factory_(this) {
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 void PermissionContextBase::DecidePermission( 92 void PermissionContextBase::DecidePermission(
93 content::WebContents* web_contents, 93 content::WebContents* web_contents,
94 const PermissionRequestID& id, 94 const PermissionRequestID& id,
95 const GURL& requesting_origin, 95 const GURL& requesting_origin,
96 const GURL& embedding_origin, 96 const GURL& embedding_origin,
97 bool user_gesture, 97 bool user_gesture,
98 const BrowserPermissionCallback& callback) { 98 const BrowserPermissionCallback& callback) {
99 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)); 99 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
100 100
101 if (!requesting_origin.is_valid() || !embedding_origin.is_valid()) { 101 if (!requesting_origin.is_valid() || !embedding_origin.is_valid()) {
102 DVLOG(1) 102 std::string type_name =
103 << "Attempt to use " << content_settings::GetTypeName(permission_type_) 103 content_settings::WebsiteSettingsRegistry::GetInstance()
104 << " from an invalid URL: " << requesting_origin 104 ->Get(permission_type_)
105 << "," << embedding_origin 105 ->name();
106 << " (" << content_settings::GetTypeName(permission_type_) 106
107 << " is not supported in popups)"; 107 DVLOG(1) << "Attempt to use " << type_name
108 << " from an invalid URL: " << requesting_origin << ","
109 << embedding_origin << " (" << type_name
110 << " is not supported in popups)";
108 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback, 111 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
109 false /* persist */, CONTENT_SETTING_BLOCK); 112 false /* persist */, CONTENT_SETTING_BLOCK);
110 return; 113 return;
111 } 114 }
112 115
113 if (IsRestrictedToSecureOrigins() && 116 if (IsRestrictedToSecureOrigins() &&
114 !content::IsOriginSecure(requesting_origin)) { 117 !content::IsOriginSecure(requesting_origin)) {
115 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback, 118 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
116 false /* persist */, CONTENT_SETTING_BLOCK); 119 false /* persist */, CONTENT_SETTING_BLOCK);
117 return; 120 return;
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 DCHECK_EQ(requesting_origin, requesting_origin.GetOrigin()); 245 DCHECK_EQ(requesting_origin, requesting_origin.GetOrigin());
243 DCHECK_EQ(embedding_origin, embedding_origin.GetOrigin()); 246 DCHECK_EQ(embedding_origin, embedding_origin.GetOrigin());
244 DCHECK(content_setting == CONTENT_SETTING_ALLOW || 247 DCHECK(content_setting == CONTENT_SETTING_ALLOW ||
245 content_setting == CONTENT_SETTING_BLOCK); 248 content_setting == CONTENT_SETTING_BLOCK);
246 249
247 profile_->GetHostContentSettingsMap()->SetContentSetting( 250 profile_->GetHostContentSettingsMap()->SetContentSetting(
248 ContentSettingsPattern::FromURLNoWildcard(requesting_origin), 251 ContentSettingsPattern::FromURLNoWildcard(requesting_origin),
249 ContentSettingsPattern::FromURLNoWildcard(embedding_origin), 252 ContentSettingsPattern::FromURLNoWildcard(embedding_origin),
250 permission_type_, std::string(), content_setting); 253 permission_type_, std::string(), content_setting);
251 } 254 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698