chrome/renderer/resources/extensions/omnibox_custom_bindings.js - Issue 12517011: Added activity logging for ext APIs with custom bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/omnibox_custom_bindings.js

Issue 12517011: Added activity logging for ext APIs with custom bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Modified setHandleRequest to avoid double logging Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/omnibox_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/omnibox_custom_bindings.js b/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

index fa0ced3aa34515132f9f4c72a0a07b71fe0ea065..51404c3a813240fba70de90e05f54b8d3afc60c8 100644

--- a/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

@@ -87,7 +87,7 @@ binding.registerCustomHook(function(bindingsAPI) {

apiFunctions.setHandleRequest('setDefaultSuggestion', function(details) {

var parseResult = parseOmniboxDescription(details.description);

sendRequest(this.name, [parseResult], this.definition.parameters);

- });

+ }, true);

apiFunctions.setUpdateArgumentsPostValidate(

'sendSuggestions', function(requestId, userSuggestions) {